From: Radu Nicolau <radu.nicolau@intel.com>
To: Konyukhov Aleksandr <Alexander.Konyukhov@kaspersky.com>,
Kai Ji <kai.ji@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
"Declan Doherty" <declan.doherty@intel.com>,
Fan Zhang <fanzhang.oss@gmail.com>
Cc: <sdl.dpdk@linuxtesting.org>, <dev@dpdk.org>, <stable@dpdk.org>,
<roy.fan.zhang@intel.com>
Subject: Re: [PATCH v2] crypto/ipsec_mb: fix Null ptr dereference in set_mb_job_params()
Date: Tue, 6 Oct 2026 11:57:58 +0100 [thread overview]
Message-ID: <ceeb7468-d1b6-49cf-8c42-197bd6af81bd@intel.com> (raw)
In-Reply-To: <20261002112046.601087-1-Alexander.Konyukhov@kaspersky.com>
On 02-Oct-26 12:20 PM, Konyukhov Aleksandr wrote:
> In function set_mb_job_params pmd_aesni_mb.c:1742 check
> (cipher_mode == IMB_CIPHER_NULL && oop)
> is not enath to garanteed job->dst != 0, which in turn could lead to
> NULL ptr dereference.
>
> Add new check for (sgl == 0) to be shure that job->dst
> was set in pmd_aesni_mb.c:1610
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 03944ff5e3df ("crypto/ipsec_mb: support null auth/cipher for aesni_mb")
> Cc: roy.fan.zhang@intel.com
>
> Signed-off-by: Konyukhov Aleksandr <Alexander.Konyukhov@kaspersky.com>
> ---
Hi, I send a patch that is basically your first fix and a comment and
CC'd stable dpdk mailing list - the NULL SGL OOP case was actually
handled by the existing code, your initial fix was fine, thanks for
taking the time.
I also added test cases to verify the fix and cover this case.
prev parent reply other threads:[~2026-10-06 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 11:20 [PATCH v2] crypto/ipsec_mb: fix Null ptr dereference in set_mb_job_params() Konyukhov Aleksandr
2026-10-06 10:57 ` Radu Nicolau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceeb7468-d1b6-49cf-8c42-197bd6af81bd@intel.com \
--to=radu.nicolau@intel.com \
--cc=Alexander.Konyukhov@kaspersky.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=kai.ji@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=sdl.dpdk@linuxtesting.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox