[PATCH v2] crypto/ipsec_mb: fix Null ptr dereference in set_mb_job_params()

[PATCH v2] crypto/ipsec_mb: fix Null ptr dereference in set_mb_job_params()

[Konyukhov Aleksandr]

In function set_mb_job_params pmd_aesni_mb.c:1742 check
(cipher_mode == IMB_CIPHER_NULL && oop)
is not enath to garanteed job->dst != 0, which in turn could lead to
NULL ptr dereference.

Add new check for (sgl == 0) to be shure that job->dst
was set in pmd_aesni_mb.c:1610

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 03944ff5e3df ("crypto/ipsec_mb: support null auth/cipher for aesni_mb")
Cc: roy.fan.zhang@intel.com

Signed-off-by: Konyukhov Aleksandr <Alexander.Konyukhov@kaspersky.com>
---
 drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
index 05dc1a039f..e3a53d9a14 100644
--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
@@ -1739,9 +1739,13 @@ set_mb_job_params(IMB_JOB *job, struct ipsec_mb_qp *qp,
 	}
 
 	if (cipher_mode == IMB_CIPHER_NULL && oop) {
-		memcpy(job->dst + job->cipher_start_src_offset_in_bytes,
-			job->src + job->cipher_start_src_offset_in_bytes,
-			job->msg_len_to_cipher_in_bytes);
+		if (!sgl) {
+			memcpy(job->dst + job->cipher_start_src_offset_in_bytes,
+				job->src + job->cipher_start_src_offset_in_bytes,
+				job->msg_len_to_cipher_in_bytes);
+		} else {
+			return -1;
+		}
 	}
 
 	/* Set user data to be crypto operation data struct */
-- 
2.43.0

Re: [PATCH v2] crypto/ipsec_mb: fix Null ptr dereference in set_mb_job_params()

[Radu Nicolau]

On 02-Oct-26 12:20 PM, Konyukhov Aleksandr wrote:
> In function set_mb_job_params pmd_aesni_mb.c:1742 check
> (cipher_mode == IMB_CIPHER_NULL && oop)
> is not enath to garanteed job->dst != 0, which in turn could lead to
> NULL ptr dereference.
>
> Add new check for (sgl == 0) to be shure that job->dst
> was set in pmd_aesni_mb.c:1610
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 03944ff5e3df ("crypto/ipsec_mb: support null auth/cipher for aesni_mb")
> Cc: roy.fan.zhang@intel.com
>
> Signed-off-by: Konyukhov Aleksandr <Alexander.Konyukhov@kaspersky.com>
> ---

Hi, I send a patch that is basically your first fix and a comment and 
CC'd stable dpdk mailing list - the NULL SGL OOP case was actually 
handled by the existing code, your initial fix was fine, thanks for 
taking the time.

I also added test cases to verify the fix and cover this case.