* [PATCH v1 1/2] net/i40e: do not use flow RSS conf struct
2026-08-19 14:23 [PATCH v1 0/2] I40E refactors Anatoly Burakov
@ 2026-08-19 14:23 ` Anatoly Burakov
2026-08-19 14:23 ` [PATCH v1 2/2] net/i40e: move mutable fields out of RSS config Anatoly Burakov
1 sibling, 0 replies; 3+ messages in thread
From: Anatoly Burakov @ 2026-08-19 14:23 UTC (permalink / raw)
To: dev, Bruce Richardson
Currently, the RSS filter structure includes an rte_flow RSS conf structure
directly. This is suboptimal, because that structure has pointers in it,
which makes copying data out of this structure a non-trivial operation that
may introduce potentially dangling pointers to queue lists or RSS key.
Replace it with direct members of the RSS config struct, and adjust all
users accordingly.
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
drivers/net/intel/i40e/i40e_ethdev.h | 11 +++++---
drivers/net/intel/i40e/i40e_flow.c | 11 +++++---
drivers/net/intel/i40e/i40e_hash.c | 39 ++++++++++++----------------
drivers/net/intel/i40e/i40e_hash.h | 1 -
4 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/net/intel/i40e/i40e_ethdev.h b/drivers/net/intel/i40e/i40e_ethdev.h
index 9d9bde6aeb..b6f341169f 100644
--- a/drivers/net/intel/i40e/i40e_ethdev.h
+++ b/drivers/net/intel/i40e/i40e_ethdev.h
@@ -1053,12 +1053,15 @@ struct i40e_customized_pctype {
bool valid; /* Check if it's valid */
};
+#define I40E_RSS_KEY_LEN ((I40E_PFQF_HKEY_MAX_INDEX + 1) * sizeof(uint32_t))
+
struct i40e_rte_flow_rss_conf {
- struct rte_flow_action_rss conf; /**< RSS parameters. */
+ enum rte_eth_hash_function func;
+ uint64_t types; /**< Specific RSS hash types (see RTE_ETH_RSS_*). */
+ uint32_t key_len; /**< Hash key length in bytes. */
+ uint32_t queue_num; /**< Number of entries in @p queue. */
- uint8_t key[(I40E_VFQF_HKEY_MAX_INDEX > I40E_PFQF_HKEY_MAX_INDEX ?
- I40E_VFQF_HKEY_MAX_INDEX : I40E_PFQF_HKEY_MAX_INDEX + 1) *
- sizeof(uint32_t)]; /**< Hash key. */
+ uint8_t key[I40E_RSS_KEY_LEN]; /**< Hash key. */
uint16_t queue[RTE_ETH_RSS_RETA_SIZE_512]; /**< Queues indices to use. */
bool symmetric_enable; /**< true, if enable symmetric */
diff --git a/drivers/net/intel/i40e/i40e_flow.c b/drivers/net/intel/i40e/i40e_flow.c
index 6eb85a7d0d..f0eea61b1e 100644
--- a/drivers/net/intel/i40e/i40e_flow.c
+++ b/drivers/net/intel/i40e/i40e_flow.c
@@ -4338,9 +4338,14 @@ i40e_flow_query(struct rte_eth_dev *dev __rte_unused,
"action not supported");
return -rte_errno;
}
- memcpy(rss_conf,
- &rss_rule->rss_filter_info.conf,
- sizeof(struct rte_flow_action_rss));
+ *rss_conf = (struct rte_flow_action_rss){
+ .func = rss_rule->rss_filter_info.func,
+ .types = rss_rule->rss_filter_info.types,
+ .key_len = rss_rule->rss_filter_info.key_len,
+ .queue_num = rss_rule->rss_filter_info.queue_num,
+ .key = rss_rule->rss_filter_info.key,
+ .queue = rss_rule->rss_filter_info.queue,
+ };
break;
default:
return rte_flow_error_set(error, ENOTSUP,
diff --git a/drivers/net/intel/i40e/i40e_hash.c b/drivers/net/intel/i40e/i40e_hash.c
index 6a23e2bf7f..2887460125 100644
--- a/drivers/net/intel/i40e/i40e_hash.c
+++ b/drivers/net/intel/i40e/i40e_hash.c
@@ -747,7 +747,7 @@ i40e_hash_config_pctype(struct i40e_hw *hw,
struct i40e_rte_flow_rss_conf *rss_conf,
uint32_t pctype)
{
- uint64_t rss_types = rss_conf->conf.types;
+ uint64_t rss_types = rss_conf->types;
int ret;
if (rss_types == 0) {
@@ -829,17 +829,16 @@ static int
i40e_hash_config(struct i40e_pf *pf,
struct i40e_rte_flow_rss_conf *rss_conf)
{
- struct rte_flow_action_rss *rss_info = &rss_conf->conf;
struct i40e_hw *hw = &pf->adapter->hw;
uint64_t pctypes;
int ret;
- if (rss_info->func != RTE_ETH_HASH_FUNCTION_DEFAULT) {
- ret = i40e_hash_config_func(hw, rss_info->func);
+ if (rss_conf->func != RTE_ETH_HASH_FUNCTION_DEFAULT) {
+ ret = i40e_hash_config_func(hw, rss_conf->func);
if (ret)
return ret;
- if (rss_info->func != RTE_ETH_HASH_FUNCTION_TOEPLITZ)
+ if (rss_conf->func != RTE_ETH_HASH_FUNCTION_TOEPLITZ)
rss_conf->misc_reset_flags |=
I40E_HASH_FLOW_RESET_FLAG_FUNC;
}
@@ -852,9 +851,9 @@ i40e_hash_config(struct i40e_pf *pf,
rss_conf->misc_reset_flags |= I40E_HASH_FLOW_RESET_FLAG_REGION;
}
- if (rss_info->key_len > 0) {
+ if (rss_conf->key_len > 0) {
ret = i40e_set_rss_key(pf->main_vsi, rss_conf->key,
- rss_info->key_len);
+ rss_conf->key_len);
if (ret)
return ret;
@@ -862,13 +861,13 @@ i40e_hash_config(struct i40e_pf *pf,
}
/* Update lookup table */
- if (rss_info->queue_num > 0) {
+ if (rss_conf->queue_num > 0) {
uint8_t lut[RTE_ETH_RSS_RETA_SIZE_512];
uint32_t i, j = 0;
for (i = 0; i < hw->func_caps.rss_table_size; i++) {
- lut[i] = (uint8_t)rss_info->queue[j];
- j = (j == rss_info->queue_num - 1) ? 0 : (j + 1);
+ lut[i] = (uint8_t)rss_conf->queue[j];
+ j = (j == rss_conf->queue_num - 1) ? 0 : (j + 1);
}
ret = i40e_set_rss_lut(pf->main_vsi, lut, (uint16_t)i);
@@ -876,7 +875,7 @@ i40e_hash_config(struct i40e_pf *pf,
return ret;
pf->hash_enabled_queues = 0;
- for (i = 0; i < rss_info->queue_num; i++)
+ for (i = 0; i < rss_conf->queue_num; i++)
pf->hash_enabled_queues |= BIT_ULL(lut[i]);
pf->adapter->rss_reta_updated = 0;
@@ -933,8 +932,7 @@ i40e_hash_parse_key(const struct rte_flow_action_rss *rss_act,
memcpy(rss_conf->key, key, sizeof(rss_conf->key));
}
- rss_conf->conf.key = rss_conf->key;
- rss_conf->conf.key_len = sizeof(rss_conf->key);
+ rss_conf->key_len = sizeof(rss_conf->key);
}
static int
@@ -949,8 +947,8 @@ i40e_hash_parse_pattern_act(const struct rte_eth_dev *dev,
if (rss_act->key_len)
i40e_hash_parse_key(rss_act, rss_conf);
- rss_conf->conf.func = rss_act->func;
- rss_conf->conf.types = rss_act->types;
+ rss_conf->func = rss_act->func;
+ rss_conf->types = rss_act->types;
rss_conf->inset = i40e_hash_get_inset(rss_act->types, rss_conf->symmetric_enable);
return i40e_hash_get_pattern_pctypes(dev, pattern, rss_act,
@@ -963,8 +961,7 @@ i40e_hash_parse_queues(const struct rte_flow_action_rss *rss_act,
{
memcpy(rss_conf->queue, rss_act->queue,
rss_act->queue_num * sizeof(rss_conf->queue[0]));
- rss_conf->conf.queue = rss_conf->queue;
- rss_conf->conf.queue_num = rss_act->queue_num;
+ rss_conf->queue_num = rss_act->queue_num;
return 0;
}
@@ -1277,7 +1274,7 @@ i40e_hash_parse(struct rte_eth_dev *dev,
return ret;
rss_act = parsed_actions.actions[0]->conf;
/* set up RSS functions */
- rss_conf->conf.func = rss_act->func;
+ rss_conf->func = rss_act->func;
return i40e_hash_parse_queue_region(pattern, rss_act, rss_conf, error);
}
/* Empty pattern path */
@@ -1287,7 +1284,7 @@ i40e_hash_parse(struct rte_eth_dev *dev,
if (ret)
return ret;
rss_act = parsed_actions.actions[0]->conf;
- rss_conf->conf.func = rss_act->func;
+ rss_conf->func = rss_act->func;
/* if there is a queue list, take that path */
if (rss_act->queue != NULL)
return i40e_hash_parse_queues(rss_act, rss_conf);
@@ -1379,10 +1376,6 @@ i40e_hash_filter_create(struct i40e_pf *pf,
new_conf = &filter->rss_filter_info;
memcpy(new_conf, rss_conf, sizeof(*new_conf));
- if (new_conf->conf.queue_num)
- new_conf->conf.queue = new_conf->queue;
- if (new_conf->conf.key_len)
- new_conf->conf.key = new_conf->key;
ret = i40e_hash_config(pf, new_conf);
if (ret) {
diff --git a/drivers/net/intel/i40e/i40e_hash.h b/drivers/net/intel/i40e/i40e_hash.h
index 99df4bccd0..3bf30cdee5 100644
--- a/drivers/net/intel/i40e/i40e_hash.h
+++ b/drivers/net/intel/i40e/i40e_hash.h
@@ -27,7 +27,6 @@ int i40e_hash_filter_destroy(struct i40e_pf *pf,
const struct i40e_rss_filter *rss_filter);
int i40e_hash_filter_flush(struct i40e_pf *pf);
-#define I40E_RSS_KEY_LEN ((I40E_PFQF_HKEY_MAX_INDEX + 1) * sizeof(uint32_t))
extern const uint8_t i40e_rss_key_default[I40E_RSS_KEY_LEN];
#ifdef __cplusplus
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH v1 2/2] net/i40e: move mutable fields out of RSS config
2026-08-19 14:23 [PATCH v1 0/2] I40E refactors Anatoly Burakov
2026-08-19 14:23 ` [PATCH v1 1/2] net/i40e: do not use flow RSS conf struct Anatoly Burakov
@ 2026-08-19 14:23 ` Anatoly Burakov
1 sibling, 0 replies; 3+ messages in thread
From: Anatoly Burakov @ 2026-08-19 14:23 UTC (permalink / raw)
To: dev, Bruce Richardson
Currently, the RSS filter configuration structure contains both data that
is received from rte_flow API call, as well as some metadata for internal
use (to decide on whether to reset the RSS configuration when removing the
flow).
To separate these, move the metadata out of RSS configuration into a
separate structure stored in RSS filter node.
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
drivers/net/intel/i40e/i40e_ethdev.h | 7 +++
drivers/net/intel/i40e/i40e_hash.c | 86 ++++++++++++++--------------
2 files changed, 50 insertions(+), 43 deletions(-)
diff --git a/drivers/net/intel/i40e/i40e_ethdev.h b/drivers/net/intel/i40e/i40e_ethdev.h
index b6f341169f..1e64a2d280 100644
--- a/drivers/net/intel/i40e/i40e_ethdev.h
+++ b/drivers/net/intel/i40e/i40e_ethdev.h
@@ -1071,7 +1071,13 @@ struct i40e_rte_flow_rss_conf {
uint8_t region_priority; /**< queue region priority */
uint8_t region_queue_num; /**< region queue number */
uint16_t region_queue_start; /**< region queue start */
+};
+/*
+ * Metadata for an installed RSS filter. Records which parts of the RSS
+ * configuration this filter owns, so they can be reset when filter is removed.
+ */
+struct i40e_rss_filter_data {
uint32_t misc_reset_flags;
#define I40E_HASH_FLOW_RESET_FLAG_FUNC 0x01UL
#define I40E_HASH_FLOW_RESET_FLAG_KEY 0x02UL
@@ -1088,6 +1094,7 @@ struct i40e_rte_flow_rss_conf {
struct i40e_rss_filter {
TAILQ_ENTRY(i40e_rss_filter) next;
struct i40e_rte_flow_rss_conf rss_filter_info;
+ struct i40e_rss_filter_data filter_data;
};
TAILQ_HEAD(i40e_rss_conf_list, i40e_rss_filter);
diff --git a/drivers/net/intel/i40e/i40e_hash.c b/drivers/net/intel/i40e/i40e_hash.c
index 2887460125..17adcbaa27 100644
--- a/drivers/net/intel/i40e/i40e_hash.c
+++ b/drivers/net/intel/i40e/i40e_hash.c
@@ -827,8 +827,10 @@ i40e_hash_config_region(struct i40e_pf *pf,
static int
i40e_hash_config(struct i40e_pf *pf,
- struct i40e_rte_flow_rss_conf *rss_conf)
+ struct i40e_rss_filter *filter)
{
+ struct i40e_rte_flow_rss_conf *rss_conf = &filter->rss_filter_info;
+ struct i40e_rss_filter_data *filter_data = &filter->filter_data;
struct i40e_hw *hw = &pf->adapter->hw;
uint64_t pctypes;
int ret;
@@ -839,7 +841,7 @@ i40e_hash_config(struct i40e_pf *pf,
return ret;
if (rss_conf->func != RTE_ETH_HASH_FUNCTION_TOEPLITZ)
- rss_conf->misc_reset_flags |=
+ filter_data->misc_reset_flags |=
I40E_HASH_FLOW_RESET_FLAG_FUNC;
}
@@ -848,7 +850,7 @@ i40e_hash_config(struct i40e_pf *pf,
if (ret)
return ret;
- rss_conf->misc_reset_flags |= I40E_HASH_FLOW_RESET_FLAG_REGION;
+ filter_data->misc_reset_flags |= I40E_HASH_FLOW_RESET_FLAG_REGION;
}
if (rss_conf->key_len > 0) {
@@ -857,7 +859,7 @@ i40e_hash_config(struct i40e_pf *pf,
if (ret)
return ret;
- rss_conf->misc_reset_flags |= I40E_HASH_FLOW_RESET_FLAG_KEY;
+ filter_data->misc_reset_flags |= I40E_HASH_FLOW_RESET_FLAG_KEY;
}
/* Update lookup table */
@@ -879,7 +881,7 @@ i40e_hash_config(struct i40e_pf *pf,
pf->hash_enabled_queues |= BIT_ULL(lut[i]);
pf->adapter->rss_reta_updated = 0;
- rss_conf->misc_reset_flags |= I40E_HASH_FLOW_RESET_FLAG_QUEUE;
+ filter_data->misc_reset_flags |= I40E_HASH_FLOW_RESET_FLAG_QUEUE;
}
/* The codes behind configure the input sets and symmetric hash
@@ -906,14 +908,14 @@ i40e_hash_config(struct i40e_pf *pf,
if (ret)
return ret;
- rss_conf->reset_symmetric_pctypes |= bit;
+ filter_data->reset_symmetric_pctypes |= bit;
}
ret = i40e_hash_config_pctype(hw, rss_conf, idx);
if (ret)
return ret;
- rss_conf->reset_config_pctypes |= bit;
+ filter_data->reset_config_pctypes |= bit;
pctypes &= ~bit;
} while (pctypes);
@@ -1306,21 +1308,25 @@ i40e_hash_parse(struct rte_eth_dev *dev,
}
static void
-i40e_invalid_rss_filter(const struct i40e_rte_flow_rss_conf *ref_conf,
- struct i40e_rte_flow_rss_conf *conf)
+i40e_invalid_rss_filter(const struct i40e_rss_filter *ref,
+ struct i40e_rss_filter *filter)
{
- uint32_t reset_flags = conf->misc_reset_flags;
+ const struct i40e_rte_flow_rss_conf *ref_conf = &ref->rss_filter_info;
+ const struct i40e_rss_filter_data *ref_data = &ref->filter_data;
+ const struct i40e_rte_flow_rss_conf *conf = &filter->rss_filter_info;
+ struct i40e_rss_filter_data *data = &filter->filter_data;
+ uint32_t reset_flags = data->misc_reset_flags;
- conf->misc_reset_flags &= ~ref_conf->misc_reset_flags;
+ data->misc_reset_flags &= ~ref_data->misc_reset_flags;
if ((reset_flags & I40E_HASH_FLOW_RESET_FLAG_REGION) &&
- (ref_conf->misc_reset_flags & I40E_HASH_FLOW_RESET_FLAG_REGION) &&
+ (ref_data->misc_reset_flags & I40E_HASH_FLOW_RESET_FLAG_REGION) &&
(conf->region_queue_start != ref_conf->region_queue_start ||
conf->region_queue_num != ref_conf->region_queue_num))
- conf->misc_reset_flags |= I40E_HASH_FLOW_RESET_FLAG_REGION;
+ data->misc_reset_flags |= I40E_HASH_FLOW_RESET_FLAG_REGION;
- conf->reset_config_pctypes &= ~ref_conf->reset_config_pctypes;
- conf->reset_symmetric_pctypes &= ~ref_conf->reset_symmetric_pctypes;
+ data->reset_config_pctypes &= ~ref_data->reset_config_pctypes;
+ data->reset_symmetric_pctypes &= ~ref_data->reset_symmetric_pctypes;
}
int
@@ -1330,15 +1336,11 @@ i40e_hash_filter_restore(struct i40e_pf *pf)
int ret;
TAILQ_FOREACH(filter, &pf->rss_config_list, next) {
- struct i40e_rte_flow_rss_conf *rss_conf =
- &filter->rss_filter_info;
struct i40e_rss_filter *prev;
- rss_conf->misc_reset_flags = 0;
- rss_conf->reset_config_pctypes = 0;
- rss_conf->reset_symmetric_pctypes = 0;
+ filter->filter_data = (struct i40e_rss_filter_data){0};
- ret = i40e_hash_config(pf, rss_conf);
+ ret = i40e_hash_config(pf, filter);
if (ret) {
pf->hash_filter_enabled = 0;
i40e_pf_disable_rss(pf);
@@ -1351,8 +1353,7 @@ i40e_hash_filter_restore(struct i40e_pf *pf)
TAILQ_FOREACH(prev, &pf->rss_config_list, next) {
if (prev == filter)
break;
- i40e_invalid_rss_filter(rss_conf,
- &prev->rss_filter_info);
+ i40e_invalid_rss_filter(filter, prev);
}
}
@@ -1377,7 +1378,7 @@ i40e_hash_filter_create(struct i40e_pf *pf,
memcpy(new_conf, rss_conf, sizeof(*new_conf));
- ret = i40e_hash_config(pf, new_conf);
+ ret = i40e_hash_config(pf, filter);
if (ret) {
rte_free(filter);
if (i40e_pf_config_rss(pf))
@@ -1389,7 +1390,7 @@ i40e_hash_filter_create(struct i40e_pf *pf,
/* Invalid previous RSS filter */
TAILQ_FOREACH(prev, &pf->rss_config_list, next)
- i40e_invalid_rss_filter(new_conf, &prev->rss_filter_info);
+ i40e_invalid_rss_filter(filter, prev);
TAILQ_INSERT_TAIL(&pf->rss_config_list, filter, next);
return 0;
@@ -1397,7 +1398,7 @@ i40e_hash_filter_create(struct i40e_pf *pf,
static int
i40e_hash_reset_conf(struct i40e_pf *pf,
- struct i40e_rte_flow_rss_conf *rss_conf)
+ struct i40e_rss_filter_data *filter_data)
{
struct i40e_hw *hw = &pf->adapter->hw;
struct rte_eth_dev *dev;
@@ -1405,32 +1406,32 @@ i40e_hash_reset_conf(struct i40e_pf *pf,
uint32_t idx;
int ret;
- if (rss_conf->misc_reset_flags & I40E_HASH_FLOW_RESET_FLAG_FUNC) {
+ if (filter_data->misc_reset_flags & I40E_HASH_FLOW_RESET_FLAG_FUNC) {
ret = i40e_hash_config_func(hw, RTE_ETH_HASH_FUNCTION_TOEPLITZ);
if (ret)
return ret;
- rss_conf->misc_reset_flags &= ~I40E_HASH_FLOW_RESET_FLAG_FUNC;
+ filter_data->misc_reset_flags &= ~I40E_HASH_FLOW_RESET_FLAG_FUNC;
}
- if (rss_conf->misc_reset_flags & I40E_HASH_FLOW_RESET_FLAG_REGION) {
+ if (filter_data->misc_reset_flags & I40E_HASH_FLOW_RESET_FLAG_REGION) {
dev = &rte_eth_devices[pf->dev_data->port_id];
ret = i40e_flush_queue_region_all_conf(dev, hw, pf, 0);
if (ret)
return ret;
- rss_conf->misc_reset_flags &= ~I40E_HASH_FLOW_RESET_FLAG_REGION;
+ filter_data->misc_reset_flags &= ~I40E_HASH_FLOW_RESET_FLAG_REGION;
}
- if (rss_conf->misc_reset_flags & I40E_HASH_FLOW_RESET_FLAG_KEY) {
+ if (filter_data->misc_reset_flags & I40E_HASH_FLOW_RESET_FLAG_KEY) {
ret = i40e_pf_reset_rss_key(pf);
if (ret)
return ret;
- rss_conf->misc_reset_flags &= ~I40E_HASH_FLOW_RESET_FLAG_KEY;
+ filter_data->misc_reset_flags &= ~I40E_HASH_FLOW_RESET_FLAG_KEY;
}
- if (rss_conf->misc_reset_flags & I40E_HASH_FLOW_RESET_FLAG_QUEUE) {
+ if (filter_data->misc_reset_flags & I40E_HASH_FLOW_RESET_FLAG_QUEUE) {
if (!pf->adapter->rss_reta_updated) {
ret = i40e_pf_reset_rss_reta(pf);
if (ret)
@@ -1438,11 +1439,11 @@ i40e_hash_reset_conf(struct i40e_pf *pf,
}
pf->hash_enabled_queues = 0;
- rss_conf->misc_reset_flags &= ~I40E_HASH_FLOW_RESET_FLAG_QUEUE;
+ filter_data->misc_reset_flags &= ~I40E_HASH_FLOW_RESET_FLAG_QUEUE;
}
- while (rss_conf->reset_config_pctypes) {
- idx = rte_bsf64(rss_conf->reset_config_pctypes);
+ while (filter_data->reset_config_pctypes) {
+ idx = rte_bsf64(filter_data->reset_config_pctypes);
i40e_hash_enable_pctype(hw, idx, false);
inset = i40e_get_default_input_set(idx);
@@ -1452,17 +1453,17 @@ i40e_hash_reset_conf(struct i40e_pf *pf,
return ret;
}
- rss_conf->reset_config_pctypes &= ~BIT_ULL(idx);
+ filter_data->reset_config_pctypes &= ~BIT_ULL(idx);
}
- while (rss_conf->reset_symmetric_pctypes) {
- idx = rte_bsf64(rss_conf->reset_symmetric_pctypes);
+ while (filter_data->reset_symmetric_pctypes) {
+ idx = rte_bsf64(filter_data->reset_symmetric_pctypes);
ret = i40e_hash_config_pctype_symmetric(hw, idx, false);
if (ret)
return ret;
- rss_conf->reset_symmetric_pctypes &= ~BIT_ULL(idx);
+ filter_data->reset_symmetric_pctypes &= ~BIT_ULL(idx);
}
return 0;
@@ -1477,8 +1478,7 @@ i40e_hash_filter_destroy(struct i40e_pf *pf,
TAILQ_FOREACH(filter, &pf->rss_config_list, next) {
if (rss_filter == filter) {
- ret = i40e_hash_reset_conf(pf,
- &filter->rss_filter_info);
+ ret = i40e_hash_reset_conf(pf, &filter->filter_data);
if (ret)
return ret;
@@ -1505,7 +1505,7 @@ i40e_hash_filter_flush(struct i40e_pf *pf)
int ret;
ret = i40e_hash_reset_conf(pf,
- &filter->rss_filter_info);
+ &filter->filter_data);
if (ret)
return ret;
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread