From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>, <dev@dpdk.org>
Subject: Re: [PATCH v1 1/1] net/i40e: fix compile issue in raw parsing
Date: Thu, 15 Oct 2026 15:25:34 +0100 [thread overview]
Message-ID: <fcd72cd6-9db9-4650-9acd-293720699fe1@intel.com> (raw)
In-Reply-To: <9e8c2ae1de56389366cbbbc2bf92492e732c3344.1792051372.git.anatoly.burakov@intel.com>
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
On 10/15/2026 9:02 AM, Anatoly Burakov wrote:
> When parsing RAW items, we iterate over previously parsed RAW items. They
> are sized by an enum, but we should not be using an enum for indexing and
> comparing it against an uint8_t RAW ID. Fix it by using uint8_t instead.
>
> Fixes: c8f6ee59ffe6 ("net/i40e: reimplement FDIR parser")
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> drivers/net/intel/i40e/i40e_flow_fdir.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/intel/i40e/i40e_flow_fdir.c b/drivers/net/intel/i40e/i40e_flow_fdir.c
> index cd377b218b..55997295ed 100644
> --- a/drivers/net/intel/i40e/i40e_flow_fdir.c
> +++ b/drivers/net/intel/i40e/i40e_flow_fdir.c
> @@ -799,7 +799,7 @@ i40e_fdir_node_raw_validate(const void *ctx, const struct rte_flow_item *item,
> const struct i40e_fdir_filter *fdir_filter = &fdir_ctx->fdir_filter;
> const struct rte_flow_item_raw *raw_spec = item->spec;
> const struct rte_flow_item_raw *raw_mask = item->mask;
> - enum i40e_flxpld_layer_idx raw_id = fdir_filter->input.flow_ext.raw_id;
> + uint8_t raw_id = fdir_filter->input.flow_ext.raw_id;
> size_t spec_size, spec_offset;
> size_t total_size, i;
> size_t new_src_offset;
> @@ -932,7 +932,7 @@ i40e_fdir_node_raw_process(void *ctx,
> struct i40e_fdir_filter *fdir_filter = &fdir_ctx->fdir_filter;
> const struct rte_flow_item_raw *raw_spec = item->spec;
> const struct rte_flow_item_raw *raw_mask = item->mask;
> - enum i40e_flxpld_layer_idx raw_id = fdir_filter->input.flow_ext.raw_id;
> + uint8_t raw_id = fdir_filter->input.flow_ext.raw_id;
> enum i40e_flxpld_layer_idx layer_idx = fdir_filter->input.flow_ext.layer_idx;
> struct i40e_fdir_flex_pit *flex_pit;
> size_t spec_size, spec_offset, i;
--
Regards,
Vladimir
prev parent reply other threads:[~2026-10-15 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 8:02 [PATCH v1 1/1] net/i40e: fix compile issue in raw parsing Anatoly Burakov
2026-10-15 14:25 ` Medvedkin, Vladimir [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcd72cd6-9db9-4650-9acd-293720699fe1@intel.com \
--to=vladimir.medvedkin@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox