* [PATCH v1 1/1] net/i40e: fix compile issue in raw parsing
@ 2026-10-15 8:02 Anatoly Burakov
2026-10-15 14:25 ` Medvedkin, Vladimir
0 siblings, 1 reply; 3+ messages in thread
From: Anatoly Burakov @ 2026-10-15 8:02 UTC (permalink / raw)
To: dev
When parsing RAW items, we iterate over previously parsed RAW items. They
are sized by an enum, but we should not be using an enum for indexing and
comparing it against an uint8_t RAW ID. Fix it by using uint8_t instead.
Fixes: c8f6ee59ffe6 ("net/i40e: reimplement FDIR parser")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
drivers/net/intel/i40e/i40e_flow_fdir.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/intel/i40e/i40e_flow_fdir.c b/drivers/net/intel/i40e/i40e_flow_fdir.c
index cd377b218b..55997295ed 100644
--- a/drivers/net/intel/i40e/i40e_flow_fdir.c
+++ b/drivers/net/intel/i40e/i40e_flow_fdir.c
@@ -799,7 +799,7 @@ i40e_fdir_node_raw_validate(const void *ctx, const struct rte_flow_item *item,
const struct i40e_fdir_filter *fdir_filter = &fdir_ctx->fdir_filter;
const struct rte_flow_item_raw *raw_spec = item->spec;
const struct rte_flow_item_raw *raw_mask = item->mask;
- enum i40e_flxpld_layer_idx raw_id = fdir_filter->input.flow_ext.raw_id;
+ uint8_t raw_id = fdir_filter->input.flow_ext.raw_id;
size_t spec_size, spec_offset;
size_t total_size, i;
size_t new_src_offset;
@@ -932,7 +932,7 @@ i40e_fdir_node_raw_process(void *ctx,
struct i40e_fdir_filter *fdir_filter = &fdir_ctx->fdir_filter;
const struct rte_flow_item_raw *raw_spec = item->spec;
const struct rte_flow_item_raw *raw_mask = item->mask;
- enum i40e_flxpld_layer_idx raw_id = fdir_filter->input.flow_ext.raw_id;
+ uint8_t raw_id = fdir_filter->input.flow_ext.raw_id;
enum i40e_flxpld_layer_idx layer_idx = fdir_filter->input.flow_ext.layer_idx;
struct i40e_fdir_flex_pit *flex_pit;
size_t spec_size, spec_offset, i;
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] net/i40e: fix compile issue in raw parsing
2026-10-15 8:02 [PATCH v1 1/1] net/i40e: fix compile issue in raw parsing Anatoly Burakov
@ 2026-10-15 14:25 ` Medvedkin, Vladimir
2026-10-15 17:23 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Medvedkin, Vladimir @ 2026-10-15 14:25 UTC (permalink / raw)
To: Anatoly Burakov, dev
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
On 10/15/2026 9:02 AM, Anatoly Burakov wrote:
> When parsing RAW items, we iterate over previously parsed RAW items. They
> are sized by an enum, but we should not be using an enum for indexing and
> comparing it against an uint8_t RAW ID. Fix it by using uint8_t instead.
>
> Fixes: c8f6ee59ffe6 ("net/i40e: reimplement FDIR parser")
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> drivers/net/intel/i40e/i40e_flow_fdir.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/intel/i40e/i40e_flow_fdir.c b/drivers/net/intel/i40e/i40e_flow_fdir.c
> index cd377b218b..55997295ed 100644
> --- a/drivers/net/intel/i40e/i40e_flow_fdir.c
> +++ b/drivers/net/intel/i40e/i40e_flow_fdir.c
> @@ -799,7 +799,7 @@ i40e_fdir_node_raw_validate(const void *ctx, const struct rte_flow_item *item,
> const struct i40e_fdir_filter *fdir_filter = &fdir_ctx->fdir_filter;
> const struct rte_flow_item_raw *raw_spec = item->spec;
> const struct rte_flow_item_raw *raw_mask = item->mask;
> - enum i40e_flxpld_layer_idx raw_id = fdir_filter->input.flow_ext.raw_id;
> + uint8_t raw_id = fdir_filter->input.flow_ext.raw_id;
> size_t spec_size, spec_offset;
> size_t total_size, i;
> size_t new_src_offset;
> @@ -932,7 +932,7 @@ i40e_fdir_node_raw_process(void *ctx,
> struct i40e_fdir_filter *fdir_filter = &fdir_ctx->fdir_filter;
> const struct rte_flow_item_raw *raw_spec = item->spec;
> const struct rte_flow_item_raw *raw_mask = item->mask;
> - enum i40e_flxpld_layer_idx raw_id = fdir_filter->input.flow_ext.raw_id;
> + uint8_t raw_id = fdir_filter->input.flow_ext.raw_id;
> enum i40e_flxpld_layer_idx layer_idx = fdir_filter->input.flow_ext.layer_idx;
> struct i40e_fdir_flex_pit *flex_pit;
> size_t spec_size, spec_offset, i;
--
Regards,
Vladimir
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] net/i40e: fix compile issue in raw parsing
2026-10-15 14:25 ` Medvedkin, Vladimir
@ 2026-10-15 17:23 ` Bruce Richardson
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2026-10-15 17:23 UTC (permalink / raw)
To: Medvedkin, Vladimir; +Cc: Anatoly Burakov, dev
On Thu, Oct 15, 2026 at 03:25:34PM +0100, Medvedkin, Vladimir wrote:
> Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>
> On 10/15/2026 9:02 AM, Anatoly Burakov wrote:
> > When parsing RAW items, we iterate over previously parsed RAW items. They
> > are sized by an enum, but we should not be using an enum for indexing and
> > comparing it against an uint8_t RAW ID. Fix it by using uint8_t instead.
> >
> > Fixes: c8f6ee59ffe6 ("net/i40e: reimplement FDIR parser")
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > ---
Fix squashed into offending commit in next-net-intel.
Thanks,
/Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-15 17:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-15 8:02 [PATCH v1 1/1] net/i40e: fix compile issue in raw parsing Anatoly Burakov
2026-10-15 14:25 ` Medvedkin, Vladimir
2026-10-15 17:23 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox