From: Nick Wang <nwang@suse.com>
To: philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
drbd-dev@lists.linbit.com
Cc: linux-kernel@vger.kernel.org
Subject: [Drbd-dev] [PATCH 01/10] drbd: Fix potenial risk of overlap the old history when move history.
Date: Wed, 10 Jun 2015 15:48:20 +0800 [thread overview]
Message-ID: <1433922509-10280-2-git-send-email-nwang@suse.com> (raw)
In-Reply-To: <1433922509-10280-1-git-send-email-nwang@suse.com>
Fix the potential history overlap when using more than two history uuids.
Signed-off-by: Nick Wang <nwang@suse.com>
CC: Philipp Reisner <philipp.reisner@linbit.com>
CC: Lars Ellenberg <lars.ellenberg@linbit.com>
CC: drbd-dev@lists.linbit.com
CC: linux-kernel@vger.kernel.org
---
drbd/drbd_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drbd/drbd_main.c b/drbd/drbd_main.c
index f41aa8a..2ffb569 100644
--- a/drbd/drbd_main.c
+++ b/drbd/drbd_main.c
@@ -3466,8 +3466,8 @@ void drbd_uuid_move_history(struct drbd_device *device) __must_hold(local)
{
int i;
- for (i = UI_HISTORY_START; i < UI_HISTORY_END; i++)
- device->ldev->md.uuid[i+1] = device->ldev->md.uuid[i];
+ for (i = UI_HISTORY_END; i > UI_HISTORY_START; i--)
+ device->ldev->md.uuid[i] = device->ldev->md.uuid[i-1];
}
void __drbd_uuid_set(struct drbd_device *device, int idx, u64 val) __must_hold(local)
--
1.8.4.5
next prev parent reply other threads:[~2015-06-10 7:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 7:48 [Drbd-dev] [PATCH 00/10] Zero out devices instead of initial full sync Nick Wang
2015-06-10 7:48 ` Nick Wang [this message]
2015-06-10 7:48 ` [Drbd-dev] [PATCH 02/10] Add options zap_devices to new-current-uuid for zeroing out device before initial sync Nick Wang
2015-06-10 7:48 ` [Drbd-dev] [PATCH 03/10] A function to zero out drbd backing device Nick Wang
2015-06-10 7:48 ` [Drbd-dev] [PATCH 04/10] A function to send peer node about starting zero out, using UI_FLAGS 16 Nick Wang
2015-06-10 7:48 ` [Drbd-dev] [PATCH 05/10] Start zero out device when drbdadm new-current-uuid --zap-device Nick Wang
2015-06-10 7:48 ` [Drbd-dev] [PATCH 06/10] New packet P_ZERO_OUT to get the status of zeroing out device from peer node Nick Wang
2015-06-10 7:48 ` [Drbd-dev] [PATCH 07/10] Using P_ZERO_OUT to send back device zero out status Nick Wang
2015-06-10 7:48 ` [Drbd-dev] [PATCH 08/10] Receive UI_FLAGS 16 of P_UUIDS to start zero out devices Nick Wang
2015-06-10 7:48 ` [Drbd-dev] [PATCH 09/10] Notify peer to change status after both side finished zero out Nick Wang
2015-06-10 7:48 ` [Drbd-dev] [PATCH 10/10] Update flag when receive uuid Nick Wang
2015-06-10 11:35 ` [Drbd-dev] [PATCH 00/10] Zero out devices instead of initial full sync Lars Ellenberg
2015-06-10 11:44 ` Lars Ellenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433922509-10280-2-git-send-email-nwang@suse.com \
--to=nwang@suse.com \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox