Distributed Replicated Block Device (DRBD) development
 help / color / mirror / Atom feed
From: Nick Wang <nwang@suse.com>
To: philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
	drbd-dev@lists.linbit.com
Cc: linux-kernel@vger.kernel.org
Subject: [Drbd-dev] [PATCH 05/10] Start zero out device when drbdadm new-current-uuid --zap-device
Date: Wed, 10 Jun 2015 15:48:24 +0800	[thread overview]
Message-ID: <1433922509-10280-6-git-send-email-nwang@suse.com> (raw)
In-Reply-To: <1433922509-10280-1-git-send-email-nwang@suse.com>

Two new device flags to represent peer zero out status.
Start zero out local device. 

Signed-off-by: Nick Wang <nwang@suse.com>
CC: Philipp Reisner <philipp.reisner@linbit.com>
CC: Lars Ellenberg <lars.ellenberg@linbit.com>
CC: drbd-dev@lists.linbit.com
CC: linux-kernel@vger.kernel.org

---
 drbd/drbd_int.h |  4 ++++
 drbd/drbd_nl.c  | 33 ++++++++++++++++++++++++++++++++-
 2 files changed, 36 insertions(+), 1 deletion(-)

diff --git a/drbd/drbd_int.h b/drbd/drbd_int.h
index d43adf2..b49095e 100644
--- a/drbd/drbd_int.h
+++ b/drbd/drbd_int.h
@@ -623,6 +623,10 @@ enum {
 	RS_START,		/* tell worker to start resync/OV */
 	RS_PROGRESS,		/* tell worker that resync made significant progress */
 	RS_DONE,		/* tell worker that resync is done */
+
+	/* used for zero out device */
+	ZERO_DONE,		/* succeed on zero out a device */
+	ZERO_FAIL,		/* fail to zero out a device */
 };
 
 struct drbd_bitmap; /* opaque for drbd_device */
diff --git a/drbd/drbd_nl.c b/drbd/drbd_nl.c
index 1ef4551..ad499a6 100644
--- a/drbd/drbd_nl.c
+++ b/drbd/drbd_nl.c
@@ -4001,6 +4001,7 @@ int drbd_adm_new_c_uuid(struct sk_buff *skb, struct genl_info *info)
 	enum drbd_ret_code retcode;
 	int skip_initial_sync = 0;
 	int zero_out_devices = 0;
+	int zero_out_err = 0;
 	int err;
 	struct new_c_uuid_parms args;
 
@@ -4051,7 +4052,7 @@ int drbd_adm_new_c_uuid(struct sk_buff *skb, struct genl_info *info)
 	drbd_uuid_set(device, UI_BITMAP, 0); /* Rotate UI_BITMAP to History 1, etc... */
 	drbd_uuid_new_current(device); /* New current, previous to UI_BITMAP */
 
-	if (args.clear_bm) {
+	if (args.clear_bm || args.zap_devices) {
 		err = drbd_bitmap_io(device, &drbd_bmio_clear_n_write,
 			"clear_n_write from new_c_uuid", BM_LOCKED_MASK);
 		if (err) {
@@ -4067,6 +4068,36 @@ int drbd_adm_new_c_uuid(struct sk_buff *skb, struct genl_info *info)
 					CS_VERBOSE, NULL);
 			spin_unlock_irq(&device->resource->req_lock);
 		}
+		if (zero_out_devices) {
+			drbd_send_zero_out_start(first_peer_device(device));
+			_drbd_uuid_set(device, UI_BITMAP, 0);
+			drbd_print_uuids(device, "cleared bitmap UUID for zeroing device");
+
+			/* CLear bit flag of zero out */
+			clear_bit(ZERO_DONE, &device->flags);
+			clear_bit(ZERO_FAIL, &device->flags);
+			zero_out_err = zero_out_local_device(device);
+
+			if (zero_out_err) {
+				drbd_err(device, "Failed to zero out local device\n");
+				set_bit(ZERO_FAIL, &device->flags);
+				drbd_chk_io_error(device, 1, DRBD_WRITE_ERROR);
+			} else {
+				drbd_info(device, "Finish zero out device\n");
+
+				if (test_and_clear_bit(ZERO_DONE, &device->flags)) {
+					spin_lock_irq(&device->resource->req_lock);
+					_drbd_set_state(_NS2(device, disk, D_UP_TO_DATE,
+						pdsk, D_UP_TO_DATE), CS_VERBOSE, NULL);
+					spin_unlock_irq(&device->resource->req_lock);
+				} else if (test_and_clear_bit(ZERO_FAIL, &device->flags)) {
+					drbd_info(device, "Peer device has already failed on zero out\n");
+				} else {
+					/* waiting for peer device finished */
+					set_bit(ZERO_DONE, &device->flags);
+				}
+			}
+		}
 	}
 
 	drbd_md_sync(device);
-- 
1.8.4.5


  parent reply	other threads:[~2015-06-10  7:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10  7:48 [Drbd-dev] [PATCH 00/10] Zero out devices instead of initial full sync Nick Wang
2015-06-10  7:48 ` [Drbd-dev] [PATCH 01/10] drbd: Fix potenial risk of overlap the old history when move history Nick Wang
2015-06-10  7:48 ` [Drbd-dev] [PATCH 02/10] Add options zap_devices to new-current-uuid for zeroing out device before initial sync Nick Wang
2015-06-10  7:48 ` [Drbd-dev] [PATCH 03/10] A function to zero out drbd backing device Nick Wang
2015-06-10  7:48 ` [Drbd-dev] [PATCH 04/10] A function to send peer node about starting zero out, using UI_FLAGS 16 Nick Wang
2015-06-10  7:48 ` Nick Wang [this message]
2015-06-10  7:48 ` [Drbd-dev] [PATCH 06/10] New packet P_ZERO_OUT to get the status of zeroing out device from peer node Nick Wang
2015-06-10  7:48 ` [Drbd-dev] [PATCH 07/10] Using P_ZERO_OUT to send back device zero out status Nick Wang
2015-06-10  7:48 ` [Drbd-dev] [PATCH 08/10] Receive UI_FLAGS 16 of P_UUIDS to start zero out devices Nick Wang
2015-06-10  7:48 ` [Drbd-dev] [PATCH 09/10] Notify peer to change status after both side finished zero out Nick Wang
2015-06-10  7:48 ` [Drbd-dev] [PATCH 10/10] Update flag when receive uuid Nick Wang
2015-06-10 11:35 ` [Drbd-dev] [PATCH 00/10] Zero out devices instead of initial full sync Lars Ellenberg
2015-06-10 11:44   ` Lars Ellenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433922509-10280-6-git-send-email-nwang@suse.com \
    --to=nwang@suse.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=lars.ellenberg@linbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philipp.reisner@linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox