From: "Tobin C. Harding" <me@tobin.cc>
To: Philipp Reisner <philipp.reisner@linbit.com>,
Lars Ellenberg <lars.ellenberg@linbit.com>
Cc: drbd-dev@lists.linbit.com
Subject: [Drbd-dev] [PATCH 05/17] lru_cache: use 'unsigned int' instead of 'unsigned'
Date: Mon, 2 Oct 2017 09:34:04 +1100 [thread overview]
Message-ID: <1506897256-14072-6-git-send-email-me@tobin.cc> (raw)
In-Reply-To: <1506897256-14072-1-git-send-email-me@tobin.cc>
checkpatch emits WARNING: Prefer 'unsigned int' to bare use of
'unsigned'.
Use 'unsigned int' instead of 'unsigned'.
Signed-off-by: Tobin C. Harding <me@tobin.cc>
---
lib/lru_cache.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/lib/lru_cache.c b/lib/lru_cache.c
index 0d3c3bb..0bdb858 100644
--- a/lib/lru_cache.c
+++ b/lib/lru_cache.c
@@ -47,7 +47,7 @@ MODULE_LICENSE("GPL");
#define PARANOIA_LC_ELEMENT(lc, e) do { \
struct lru_cache *lc_ = (lc); \
struct lc_element *e_ = (e); \
- unsigned i = e_->lc_index; \
+ unsigned int i = e_->lc_index; \
BUG_ON(i >= lc_->nr_elements); \
BUG_ON(lc_->lc_element[i] != e_); } while (0)
@@ -94,15 +94,15 @@ int lc_try_lock(struct lru_cache *lc)
* or NULL on (allocation) failure.
*/
struct lru_cache *lc_create(const char *name, struct kmem_cache *cache,
- unsigned max_pending_changes,
- unsigned e_count, size_t e_size, size_t e_off)
+ unsigned int max_pending_changes,
+ unsigned int e_count, size_t e_size, size_t e_off)
{
struct hlist_head *slot = NULL;
struct lc_element **element = NULL;
struct lru_cache *lc;
struct lc_element *e;
- unsigned cache_obj_size = kmem_cache_size(cache);
- unsigned i;
+ unsigned int cache_obj_size = kmem_cache_size(cache);
+ unsigned int i;
WARN_ON(cache_obj_size < e_size);
if (cache_obj_size < e_size)
@@ -167,7 +167,7 @@ struct lru_cache *lc_create(const char *name, struct kmem_cache *cache,
return NULL;
}
-static void lc_free_by_index(struct lru_cache *lc, unsigned i)
+static void lc_free_by_index(struct lru_cache *lc, unsigned int i)
{
void *p = lc->lc_element[i];
WARN_ON(!p);
@@ -183,7 +183,7 @@ static void lc_free_by_index(struct lru_cache *lc, unsigned i)
*/
void lc_destroy(struct lru_cache *lc)
{
- unsigned i;
+ unsigned int i;
if (!lc)
return;
for (i = 0; i < lc->nr_elements; i++)
@@ -202,7 +202,7 @@ void lc_destroy(struct lru_cache *lc)
*/
void lc_reset(struct lru_cache *lc)
{
- unsigned i;
+ unsigned int i;
INIT_LIST_HEAD(&lc->in_use);
INIT_LIST_HEAD(&lc->lru);
@@ -329,7 +329,7 @@ void lc_del(struct lru_cache *lc, struct lc_element *e)
RETURN();
}
-static struct lc_element *lc_prepare_for_change(struct lru_cache *lc, unsigned new_number)
+static struct lc_element *lc_prepare_for_change(struct lru_cache *lc, unsigned int new_number)
{
struct list_head *n;
struct lc_element *e;
@@ -591,7 +591,7 @@ unsigned int lc_put(struct lru_cache *lc, struct lc_element *e)
* @lc: the lru cache to operate on
* @i: the index of the element to return
*/
-struct lc_element *lc_element_by_index(struct lru_cache *lc, unsigned i)
+struct lc_element *lc_element_by_index(struct lru_cache *lc, unsigned int i)
{
BUG_ON(i >= lc->nr_elements);
BUG_ON(lc->lc_element[i] == NULL);
--
2.7.4
next prev parent reply other threads:[~2017-10-01 22:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-01 22:33 [Drbd-dev] [PATCH 00/17] lru_cache: checkpatch clean ups Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 01/17] lru_cache: remove FSF address from licence Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 02/17] lru_cache: fix licence comment format Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 03/17] lru_cache: move trailing */ to a separate line Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 04/17] lru_cache: remove quoted string across lines Tobin C. Harding
2017-10-01 22:34 ` Tobin C. Harding [this message]
2017-10-01 22:34 ` [Drbd-dev] [PATCH 06/17] lru_cache: use kcalloc instead of kzalloc with multiply Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 07/17] lru_cache: clean macro definition Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 08/17] lru_cache: add blank line after declarations Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 09/17] lru_cache: remove space after function name Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 10/17] lru_cache: fix function argument alignment Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 11/17] lru_cache: remove multiple blank lines Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 12/17] lru_cache: remove space before tabs Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 13/17] lru_cache: move constant to the right side of test Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 14/17] lru_cache: use braces on all arms of statement Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 15/17] lru_cache: remove unnecessary space before arguments Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 16/17] lru_cache: add spaces around '|' Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 17/17] lru_cache: move EXPORT_SYMBOL macro to follow function Tobin C. Harding
2017-10-02 13:13 ` [Drbd-dev] [PATCH 00/17] lru_cache: checkpatch clean ups Lars Ellenberg
2017-10-02 22:06 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506897256-14072-6-git-send-email-me@tobin.cc \
--to=me@tobin.cc \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox