Distributed Replicated Block Device (DRBD) development
 help / color / mirror / Atom feed
From: "Tobin C. Harding" <me@tobin.cc>
To: Philipp Reisner <philipp.reisner@linbit.com>,
	Lars Ellenberg <lars.ellenberg@linbit.com>
Cc: drbd-dev@lists.linbit.com
Subject: [Drbd-dev] [PATCH 07/17] lru_cache: clean macro definition
Date: Mon,  2 Oct 2017 09:34:06 +1100	[thread overview]
Message-ID: <1506897256-14072-8-git-send-email-me@tobin.cc> (raw)
In-Reply-To: <1506897256-14072-1-git-send-email-me@tobin.cc>

checkpatch emits ERROR: trailing statements should be on next line.
Also macro definition is slightly cluttered. If we lay the definition
out more cleanly the code is easier to read.

Clean macro definition, clearing checkpatch error.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
---
 lib/lru_cache.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/lib/lru_cache.c b/lib/lru_cache.c
index 18043b9..c15df31 100644
--- a/lib/lru_cache.c
+++ b/lib/lru_cache.c
@@ -44,13 +44,14 @@ MODULE_LICENSE("GPL");
 	return x ; } while (0)
 
 /* BUG() if e is not one of the elements tracked by lc */
-#define PARANOIA_LC_ELEMENT(lc, e) do {	\
-	struct lru_cache *lc_ = (lc);	\
-	struct lc_element *e_ = (e);	\
-	unsigned int i = e_->lc_index;	\
-	BUG_ON(i >= lc_->nr_elements);	\
-	BUG_ON(lc_->lc_element[i] != e_); } while (0)
-
+#define PARANOIA_LC_ELEMENT(lc, e)			\
+	do {						\
+		struct lru_cache *lc_ = (lc);		\
+		struct lc_element *e_ = (e);		\
+		unsigned int i = e_->lc_index;		\
+		BUG_ON(i >= lc_->nr_elements);		\
+		BUG_ON(lc_->lc_element[i] != e_);	\
+	} while (0)
 
 /* We need to atomically
  *  - try to grab the lock (set LC_LOCKED)
-- 
2.7.4


  parent reply	other threads:[~2017-10-01 22:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-01 22:33 [Drbd-dev] [PATCH 00/17] lru_cache: checkpatch clean ups Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 01/17] lru_cache: remove FSF address from licence Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 02/17] lru_cache: fix licence comment format Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 03/17] lru_cache: move trailing */ to a separate line Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 04/17] lru_cache: remove quoted string across lines Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 05/17] lru_cache: use 'unsigned int' instead of 'unsigned' Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 06/17] lru_cache: use kcalloc instead of kzalloc with multiply Tobin C. Harding
2017-10-01 22:34 ` Tobin C. Harding [this message]
2017-10-01 22:34 ` [Drbd-dev] [PATCH 08/17] lru_cache: add blank line after declarations Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 09/17] lru_cache: remove space after function name Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 10/17] lru_cache: fix function argument alignment Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 11/17] lru_cache: remove multiple blank lines Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 12/17] lru_cache: remove space before tabs Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 13/17] lru_cache: move constant to the right side of test Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 14/17] lru_cache: use braces on all arms of statement Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 15/17] lru_cache: remove unnecessary space before arguments Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 16/17] lru_cache: add spaces around '|' Tobin C. Harding
2017-10-01 22:34 ` [Drbd-dev] [PATCH 17/17] lru_cache: move EXPORT_SYMBOL macro to follow function Tobin C. Harding
2017-10-02 13:13 ` [Drbd-dev] [PATCH 00/17] lru_cache: checkpatch clean ups Lars Ellenberg
2017-10-02 22:06   ` Tobin C. Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1506897256-14072-8-git-send-email-me@tobin.cc \
    --to=me@tobin.cc \
    --cc=drbd-dev@lists.linbit.com \
    --cc=lars.ellenberg@linbit.com \
    --cc=philipp.reisner@linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox