From: Jens Axboe <axboe@kernel.dk>
To: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Thomas Voegtle <tv@lio96.de>,
Philipp Reisner <philipp.reisner@linbit.com>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org,
Lars Ellenberg <lars.ellenberg@linbit.com>,
drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH] drbd: correctly submit flush bio on barrier
Date: Wed, 03 May 2023 09:39:48 -0600 [thread overview]
Message-ID: <168312838868.941317.975898202413701616.b4-ty@kernel.dk> (raw)
In-Reply-To: <20230503121937.17232-1-christoph.boehmwalder@linbit.com>
On Wed, 03 May 2023 14:19:37 +0200, Christoph Böhmwalder wrote:
> When we receive a flush command (or "barrier" in DRBD), we currently use
> a REQ_OP_FLUSH with the REQ_PREFLUSH flag set.
>
> The correct way to submit a flush bio is by using a REQ_OP_WRITE without
> any data, and set the REQ_PREFLUSH flag.
>
> Since commit b4a6bb3a67aa ("block: add a sanity check for non-write
> flush/fua bios"), this triggers a warning in the block layer, but this
> has been broken for quite some time before that.
>
> [...]
Applied, thanks!
[1/1] drbd: correctly submit flush bio on barrier
commit: 3899d94e3831ee07ea6821c032dc297aec80586a
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-05-03 15:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 12:19 [Drbd-dev] [PATCH] drbd: correctly submit flush bio on barrier Christoph Böhmwalder
2023-05-03 15:19 ` Christoph Hellwig
2023-05-03 15:39 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168312838868.941317.975898202413701616.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=christoph.boehmwalder@linbit.com \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@infradead.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
--cc=stable@vger.kernel.org \
--cc=tv@lio96.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox