[Drbd-dev] Re: [DRBD-cvs] r1559 - in branches/drbd-0.7: drbd user

[Drbd-dev] Re: [DRBD-cvs] r1559 - in branches/drbd-0.7: drbd user

[Lars Ellenberg]

[ bitte reply-to in drbd-cvs auf drbd-dev setzen ]

/ 2004-09-24 13:13:54 +0200
\ svn@svn.drbd.org:
> Author: phil
> Date: 2004-09-24 13:13:51 +0200 (Fri, 24 Sep 2004)
> New Revision: 1559
> 
> Modified:
>    branches/drbd-0.7/drbd/drbd_int.h
>    branches/drbd-0.7/user/drbdsetup.c
> Log:
> Made the "Warnung: comparison is always false due to limited 
> range of data type" warning go away on 32Bit platforms whe
> CONFIG_LBD ist not set.
> 
> 
> Modified: branches/drbd-0.7/drbd/drbd_int.h
> ===================================================================
> --- branches/drbd-0.7/drbd/drbd_int.h	2004-09-23 19:03:21 UTC (rev 1558)
> +++ branches/drbd-0.7/drbd/drbd_int.h	2004-09-24 11:13:51 UTC (rev 1559)
> @@ -968,8 +968,12 @@
>  #define BM_EXT_PER_SECT	    ( 512 / BM_BYTES_PER_EXTENT )        //   4
>   */
>  
> -#define DRBD_MAX_SECTORS \
> +#if ( !defined(CONFIG_LBD) ) && ( BITS_PER_LONG == 32 )
> +# define DRBD_MAX_SECTORS (0xffffffffLU)
> +#else 
> +# define DRBD_MAX_SECTORS \
>            ( (MD_RESERVED_SIZE*2LL - MD_BM_OFFSET) * (1LL<<(BM_EXT_SIZE_B-9)) )
> +#endif

oh well...
why not simple (sector_t) ?
just because it is then 0xffdc0000 instead of 0xffffffff ?
so what ...

	Lars Ellenberg

Re: [Drbd-dev] Re: [DRBD-cvs] r1559 - in branches/drbd-0.7: drbd user

[Philipp Reisner]

On Friday 24 September 2004 13:40, Lars Ellenberg wrote:
> [ bitte reply-to in drbd-cvs auf drbd-dev setzen ]
>

ack. done.

> > -#define DRBD_MAX_SECTORS \
> > +#if ( !defined(CONFIG_LBD) ) && ( BITS_PER_LONG == 32 )
> > +# define DRBD_MAX_SECTORS (0xffffffffLU)
> > +#else
> > +# define DRBD_MAX_SECTORS \
> >            ( (MD_RESERVED_SIZE*2LL - MD_BM_OFFSET) *
> > (1LL<<(BM_EXT_SIZE_B-9)) ) +#endif
>
> oh well...
> why not simple (sector_t) ?
> just because it is then 0xffdc0000 instead of 0xffffffff ?
> so what ...

I did not know that it would be 0xffdc0000, I did not do the
math... , OTOH it is made it explicit.

-philipp
-- 
: Dipl-Ing Philipp Reisner                      Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH          Fax +43-1-8178292-82 :
: Schönbrunnerstr 244, 1120 Vienna, Austria    http://www.linbit.com :