[Drbd-dev] DRBD-8 Patch: dont bail at startup if errors occur

[Drbd-dev] DRBD-8 Patch: dont bail at startup if errors occur

[Simon Graham]

[-- Attachment #1.1: Type: text/plain, Size: 564 bytes --]

The checked in version of the drbd init script will bail if any errors are
encountered - this means, for example, that if you experience a disk failure
(or removal), then reboot the system, NO DRBD devices will come up because
the startup will bail as soon as it encounters the problem with the failed
disk - what should happen is the bringup should continue and the DRBD
devices using the failed disk should end up Diskless - this is pretty
important in an HA environment.

The attached patch changes the startup script to continue when an error is
found.

Simon

[-- Attachment #1.2: Type: text/html, Size: 579 bytes --]

[-- Attachment #2: drbd-startup.patch --]
[-- Type: application/octet-stream, Size: 336 bytes --]

Index: sn/scripts/drbd
===================================================================
--- sn/scripts/drbd	(revision 14561)
+++ sn/scripts/drbd	(revision 14562)
@@ -61,7 +61,7 @@
 	fi
 	IFS=$IFS_O
 	$CMD || {
-	    echo -e "\ncmd $CMD failed!"; exit 20
+	    echo -e "\ncmd $CMD failed - continuing!\n"
 	}
 	IFS=$NEWLINE
     done

Re: [Drbd-dev] DRBD-8 Patch: dont bail at startup if errors occur

[Philipp Reisner]

On Friday 01 June 2007 14:25:06 Simon Graham wrote:
> The checked in version of the drbd init script will bail if any errors are
> encountered - this means, for example, that if you experience a disk
> failure (or removal), then reboot the system, NO DRBD devices will come up
> because the startup will bail as soon as it encounters the problem with the
> failed disk - what should happen is the bringup should continue and the
> DRBD devices using the failed disk should end up Diskless - this is pretty
> important in an HA environment.
>
> The attached patch changes the startup script to continue when an error is
> found.
>
> Simon


Ack, and applied.

-Phil
-- 
: Dipl-Ing Philipp Reisner                      Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH          Fax +43-1-8178292-82 :
: Vivenotgasse 48, 1120 Vienna, Austria        http://www.linbit.com :