[Drbd-dev] [DRBD-8.0 PATCH] One more place where stop=sync flag is not explicitely

[Drbd-dev] [DRBD-8.0 PATCH] One more place where stop=sync flag is not explicitely

[Graham, Simon]

[-- Attachment #1.1: Type: text/plain, Size: 170 bytes --]

The following patch fixes an issue where the STOP-SYNC flag was not
explicitly cleared when resync is required - this can lead to the resync
stalling.

 

Simon


[-- Attachment #1.2: Type: text/html, Size: 3447 bytes --]

[-- Attachment #2: 0009-One-more-place-where-stop-sync-flag-is-not-explicite.patch --]
[-- Type: application/octet-stream, Size: 844 bytes --]

From 16896a5e8b2c5862ba55849a036788ace0171c3f Mon Sep 17 00:00:00 2001
From: Simon P. Graham <Simon.Graham@stratus.com>
Date: Sun, 30 Dec 2007 16:41:57 -0500
Subject: [PATCH] One more place where stop=sync flag is not explicitely cleared when starting resync - if flag ever got set whilst sync was not in progress, this would cause sync to stall.

---
 drbd/drbd_worker.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drbd/drbd_worker.c b/drbd/drbd_worker.c
index a832f73..381278b 100644
--- a/drbd/drbd_worker.c
+++ b/drbd/drbd_worker.c
@@ -946,6 +946,7 @@ void drbd_start_resync(drbd_dev *mdev, drbd_conns_t side)
 
 		if( ns.conn == SyncTarget ) {
 			D_ASSERT(!test_bit(STOP_SYNC_TIMER,&mdev->flags));
+			clear_bit(STOP_SYNC_TIMER,&mdev->flags);
 			mod_timer(&mdev->resync_timer,jiffies);
 		}
 
-- 
1.5.4.rc1

Re: [Drbd-dev] [DRBD-8.0 PATCH] One more place where stop=sync flag is not explicitely

[Lars Ellenberg]

On Fri, Jan 11, 2008 at 10:31:31AM -0500, Graham, Simon wrote:
> The following patch fixes an issue where the STOP-SYNC flag was not explicitly
> cleared when resync is required – this can lead to the resync stalling.

probably correct.
though maybe it is not the right place to do it,
it certainly makes it more robust.


-- 
: Lars Ellenberg                            Tel +43-1-8178292-55 :
: LINBIT Information Technologies GmbH      Fax +43-1-8178292-82 :
: Vivenotgasse 48, A-1120 Vienna/Europe    http://www.linbit.com :