[Drbd-dev] Patch for an up-to-date script/patch-kernel

[Drbd-dev] Patch for an up-to-date script/patch-kernel

[Guillaume Plessis]

[-- Attachment #1.1: Type: text/plain, Size: 375 bytes --]

Hello DRBD-devs,
I encountered problems building a DRBD 8.3.2 patch with a 2.6.30.4 kernel
(missing lru_cache.h, drbd_vli.h, drbd_tracing.c and drbd_tracing.h).

You'll find as attachement a patch that fixes the patch-building process by
filling "include_linux" and "drbd_source" with the good values.

I hope it will be useful.

Keep up the good work.

--
Guillaume Plessis

[-- Attachment #1.2: Type: text/html, Size: 541 bytes --]

[-- Attachment #2: 83-patch-kernel_fix.patch --]
[-- Type: application/octet-stream, Size: 750 bytes --]

diff -urN drbd-8.3.2.orig/scripts/patch-kernel drbd-8.3.2/scripts/patch-kernel
--- drbd-8.3.2.orig/scripts/patch-kernel	2009-06-09 11:33:03.000000000 +0000
+++ drbd-8.3.2/scripts/patch-kernel	2009-08-16 14:22:25.000000000 +0000
@@ -90,11 +90,11 @@
 #
 # Pull in the base drbd source
 #
-include_linux="drbd.h drbd_limits.h drbd_nl.h drbd_tag_magic.h"
+include_linux="drbd.h drbd_limits.h drbd_nl.h drbd_tag_magic.h lru_cache.h"
 drbd_source="drbd_actlog.c drbd_bitmap.c drbd_buildtag.c
 	drbd_wrappers.h drbd_int.h drbd_main.c drbd_nl.c drbd_proc.c
 	drbd_receiver.c drbd_req.c drbd_req.h drbd_strings.c drbd_worker.c
-	lru_cache.c lru_cache.h"
+	lru_cache.c drbd_vli.h drbd_tracing.c drbd_tracing.h"
 
 # clean it first
 make -s -C $DRBD/drbd clean

Re: [Drbd-dev] Patch for an up-to-date script/patch-kernel

[Philipp Reisner]

Am Sonntag, 16. August 2009 18:00:21 schrieb Guillaume Plessis:
> Hello DRBD-devs,
> I encountered problems building a DRBD 8.3.2 patch with a 2.6.30.4 kernel
> (missing lru_cache.h, drbd_vli.h, drbd_tracing.c and drbd_tracing.h).
>
> You'll find as attachement a patch that fixes the patch-building process by
> filling "include_linux" and "drbd_source" with the good values.
>
> I hope it will be useful.
>
> Keep up the good work.
>

Whow the second patch of this kind within a few days. I never expected
that people actually patch DRBD into their kernels...

I have applied it.

Other than that we aim to get DRBD merged to Linux upstream with the 
2.6.32 release. You can track out integration work from here:

git://git.drbd.org/linux-2.6-drbd.git

-Phil

Re: [Drbd-dev] Patch for an up-to-date script/patch-kernel

[Guillaume Plessis]

[-- Attachment #1: Type: text/plain, Size: 804 bytes --]

Hello,
I use the patch method to avoid CONFIG_MODULES to be set.
That's one more way to prevent malicious kernel modules to be loaded on
risky machines (web servers with unsecure PHP application => www-data shell
access => privilege escalation => malicious module loaded).

Thanks for the patch having been applyed and good news that DRBD is getting
merged to Linux upstream!

--
Guillaume Plessis



2009/8/18 Philipp Reisner <philipp.reisner@linbit.com>

>
> Whow the second patch of this kind within a few days. I never expected
> that people actually patch DRBD into their kernels...
>
> I have applied it.
>
> Other than that we aim to get DRBD merged to Linux upstream with the
> 2.6.32 release. You can track out integration work from here:
>
> git://git.drbd.org/linux-2.6-drbd.git
>
> -Phil
>
>

[-- Attachment #2: Type: text/html, Size: 1304 bytes --]

Re: [Drbd-dev] Patch for an up-to-date script/patch-kernel

[Anthony.D'Ambrosio]

Thanks also for the fix and thumbs up on the core Linux merge! (We discovered the resulting kernel build errors, and being a good lazy developer figured you folks would fix it and moved on to some other tasks while we waited.  Thanks to Guillaume for the fix.)

We patch for the same reason.

Anthony
________________________________________
From: drbd-dev-bounces@lists.linbit.com [drbd-dev-bounces@lists.linbit.com] On Behalf Of Guillaume Plessis [gui@moolfreet.com]
Sent: Tuesday, August 18, 2009 5:16 PM
To: drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] Patch for an up-to-date script/patch-kernel

Hello,

I use the patch method to avoid CONFIG_MODULES to be set.
That's one more way to prevent malicious kernel modules to be loaded on risky machines (web servers with unsecure PHP application => www-data shell access => privilege escalation => malicious module loaded).

Thanks for the patch having been applyed and good news that DRBD is getting merged to Linux upstream!

--
Guillaume Plessis



2009/8/18 Philipp Reisner <philipp.reisner@linbit.com<mailto:philipp.reisner@linbit.com>>

Whow the second patch of this kind within a few days. I never expected
that people actually patch DRBD into their kernels...

I have applied it.

Other than that we aim to get DRBD merged to Linux upstream with the
2.6.32 release. You can track out integration work from here:

git://git.drbd.org/linux-2.6-drbd.git<http://git.drbd.org/linux-2.6-drbd.git>

-Phil