[Drbd-dev] [patch 5/5] drbd: fix test of unsigned in _drbd_fault_random()

[Drbd-dev] [patch 5/5] drbd: fix test of unsigned in _drbd_fault_random()

[akpm]

From: Roel Kluin <roel.kluin@gmail.com>

rsp->count is unsigned so the test does not work.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Lars Ellenberg <drbd-dev@lists.linbit.com>
Cc: Philipp Reisner <philipp.reisner@linbit.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/block/drbd/drbd_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/block/drbd/drbd_main.c~drbd-fix-test-of-unsigned-in-_drbd_fault_random drivers/block/drbd/drbd_main.c
--- a/drivers/block/drbd/drbd_main.c~drbd-fix-test-of-unsigned-in-_drbd_fault_random
+++ a/drivers/block/drbd/drbd_main.c
@@ -3623,7 +3623,7 @@ _drbd_fault_random(struct fault_random_s
 {
 	long refresh;
 
-	if (--rsp->count < 0) {
+	if (!rsp->count--) {
 		get_random_bytes(&refresh, sizeof(refresh));
 		rsp->state += refresh;
 		rsp->count = FAULT_RANDOM_REFRESH;
_

Re: [Drbd-dev] [patch 5/5] drbd: fix test of unsigned in _drbd_fault_random()

[Philipp Reisner]

Am Dienstag, 22. Dezember 2009 01:27:52 schrieb akpm@linux-foundation.org:
> From: Roel Kluin <roel.kluin@gmail.com>
> 
> rsp->count is unsigned so the test does not work.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
[...]

This patch is on its way upstream
See http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=49829ea74f790d3be2e803a617e714f5b9a5ed50

and in the DRBD tree for old kernels...
http://git.drbd.org/?p=drbd-8.3.git;a=commit;h=f1cb8ce303a26e4763bbfb32660643322f4e228d

-Phil
-- 
: Dipl-Ing Philipp Reisner
: LINBIT | Your Way to High Availability
: Tel: +43-1-8178292-50, Fax: +43-1-8178292-82
: http://www.linbit.com

DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.

Re: [Drbd-dev] [patch 5/5] drbd: fix test of unsigned in _drbd_fault_random()

[Jens Axboe]

On Tue, Dec 22 2009, Philipp Reisner wrote:
> Am Dienstag, 22. Dezember 2009 01:27:52 schrieb akpm@linux-foundation.org:
> > From: Roel Kluin <roel.kluin@gmail.com>
> > 
> > rsp->count is unsigned so the test does not work.
> > 
> > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> [...]
> 
> This patch is on its way upstream
> See http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=49829ea74f790d3be2e803a617e714f5b9a5ed50
> 
> and in the DRBD tree for old kernels...
> http://git.drbd.org/?p=drbd-8.3.git;a=commit;h=f1cb8ce303a26e4763bbfb32660643322f4e228d

Indeed, it's been in my for-linus/next for a while, I'm guessing Andrew
just hasn't updated his sources for some days.

-- 
Jens Axboe

Re: [Drbd-dev] [patch 5/5] drbd: fix test of unsigned in _drbd_fault_random()

[Andrew Morton]

On Tue, 22 Dec 2009 10:13:07 +0100 Jens Axboe <jens.axboe@oracle.com> wrote:

> On Tue, Dec 22 2009, Philipp Reisner wrote:
> > Am Dienstag, 22. Dezember 2009 01:27:52 schrieb akpm@linux-foundation.org:
> > > From: Roel Kluin <roel.kluin@gmail.com>
> > > 
> > > rsp->count is unsigned so the test does not work.
> > > 
> > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> > [...]
> > 
> > This patch is on its way upstream
> > See http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=49829ea74f790d3be2e803a617e714f5b9a5ed50
> > 
> > and in the DRBD tree for old kernels...
> > http://git.drbd.org/?p=drbd-8.3.git;a=commit;h=f1cb8ce303a26e4763bbfb32660643322f4e228d
> 
> Indeed, it's been in my for-linus/next for a while, I'm guessing Andrew
> just hasn't updated his sources for some days.
> 

I pull linux-next every day.

The above patch wasn't in the Dec 19 linux-next, and Stephen won't be
doing another -next until Dec 29.

Re: [Drbd-dev] [patch 5/5] drbd: fix test of unsigned in _drbd_fault_random()

[Jens Axboe]

On Tue, Dec 22 2009, Andrew Morton wrote:
> On Tue, 22 Dec 2009 10:13:07 +0100 Jens Axboe <jens.axboe@oracle.com> wrote:
> 
> > On Tue, Dec 22 2009, Philipp Reisner wrote:
> > > Am Dienstag, 22. Dezember 2009 01:27:52 schrieb akpm@linux-foundation.org:
> > > > From: Roel Kluin <roel.kluin@gmail.com>
> > > > 
> > > > rsp->count is unsigned so the test does not work.
> > > > 
> > > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> > > [...]
> > > 
> > > This patch is on its way upstream
> > > See http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=49829ea74f790d3be2e803a617e714f5b9a5ed50
> > > 
> > > and in the DRBD tree for old kernels...
> > > http://git.drbd.org/?p=drbd-8.3.git;a=commit;h=f1cb8ce303a26e4763bbfb32660643322f4e228d
> > 
> > Indeed, it's been in my for-linus/next for a while, I'm guessing Andrew
> > just hasn't updated his sources for some days.
> > 
> 
> I pull linux-next every day.
> 
> The above patch wasn't in the Dec 19 linux-next, and Stephen won't be
> doing another -next until Dec 29.

Oh, so that's why. We/I used to have for-akpm, but with -next that has
become more tricky (since you base on that).

Anyway, not an issue for me, the only change is having to notify about
merged patches for the odd ball periods like now were Stephen isn't
doing daily releases.

-- 
Jens Axboe