Distributed Replicated Block Device (DRBD) development
 help / color / mirror / Atom feed
* [Drbd-dev] .filelist build target broken by commit d6bcfd29e249d40ebe01a573ab8573e74593422a
@ 2010-03-03 20:50 Magina, Craig
  2010-03-04 17:29 ` Lars Ellenberg
  0 siblings, 1 reply; 2+ messages in thread
From: Magina, Craig @ 2010-03-03 20:50 UTC (permalink / raw)
  To: drbd-dev

Changes were made to drbd/linux/drbd_config.h adding REL_VERSION preprocessor code.  However, the base Makefile uses a sed on that file looking for REL_VERSION to populate DIST_VERSION with, which the .filelist build target uses.  This sed was not updated to match these changes, so it gets populated with "#ifdef REL_VERSION" instead of "8.3.7".  I hit this while trying to build the tarball target in order to build an rpm from a freshly cloned drbd-8.3 repository.

Craig Magina

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Drbd-dev] .filelist build target broken by commit d6bcfd29e249d40ebe01a573ab8573e74593422a
  2010-03-03 20:50 [Drbd-dev] .filelist build target broken by commit d6bcfd29e249d40ebe01a573ab8573e74593422a Magina, Craig
@ 2010-03-04 17:29 ` Lars Ellenberg
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ellenberg @ 2010-03-04 17:29 UTC (permalink / raw)
  To: drbd-dev

On Wed, Mar 03, 2010 at 03:50:01PM -0500, Magina, Craig wrote:
> Changes were made to drbd/linux/drbd_config.h adding REL_VERSION
> preprocessor code.  However, the base Makefile uses a sed on that file
> looking for REL_VERSION to populate DIST_VERSION with, which the
> .filelist build target uses.  This sed was not updated to match these
> changes, so it gets populated with "#ifdef REL_VERSION" instead of
> "8.3.7".  I hit this while trying to build the tarball target in order
> to build an rpm from a freshly cloned drbd-8.3 repository.

Fixed.
	Thanks,
	

-- 
: Lars Ellenberg
: LINBIT | Your Way to High Availability
: DRBD/HA support and consulting http://www.linbit.com

DRBD® and LINBIT® are registered trademarks of LINBIT, Austria.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-03-04 17:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-03 20:50 [Drbd-dev] .filelist build target broken by commit d6bcfd29e249d40ebe01a573ab8573e74593422a Magina, Craig
2010-03-04 17:29 ` Lars Ellenberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox