[Drbd-dev] DRBD Resource Agent flaw when stopping

[Drbd-dev] DRBD Resource Agent flaw when stopping

[Uwe Grawert]

Hello,

in the OCF Resource Agent (ocf:linbit:drbd) is a flaw, when cleaning  
up a resource and stopping the resource afterwards. The resource agent  
returns a OCF_ERR_CONFIGURED which happens because of the following  
lines:

if [[ ${OCF_RESKEY_CRM_meta_notify_start_uname- NOT SET } = " NOT SET  
" ]]; then
	ocf_log err "you really should enable notify when using this RA"
	return $OCF_ERR_CONFIGURED
fi

After a cleanup of a started resource the variable  
OCF_RESKEY_CRM_meta_notify_start_uname is empty. A simple and quick  
solution would be to add "stop" to the following block in a case switch:

case $__OCF_ACTION in
monitor|validate-all)
:;;

This is line 778 in the Resource Agent. In my opinion it does not make  
much sense to make the "is notify enabled" check when stopping a  
resource. Hence it seems reasonable to exclude a stop action from this  
check.

Is there something that speaks against it? If not, I will send a patch  
to this list.

-- 
Uwe Grawert
Linux / Unix Consultant & Trainer
Tel.: +49 151 12051100
Mail: grawert@b1-systems.de

B1 Systems GmbH
Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de
GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537

Re: [Drbd-dev] DRBD Resource Agent flaw when stopping

[Lars Ellenberg]

On Wed, Nov 03, 2010 at 08:55:15AM +0100, Uwe Grawert wrote:
> Hello,
> 
> in the OCF Resource Agent (ocf:linbit:drbd) is a flaw, when cleaning
> up a resource and stopping the resource afterwards. The resource
> agent returns a OCF_ERR_CONFIGURED which happens because of the
> following lines:
> 
> if [[ ${OCF_RESKEY_CRM_meta_notify_start_uname- NOT SET } = " NOT
> SET " ]]; then
> 	ocf_log err "you really should enable notify when using this RA"
> 	return $OCF_ERR_CONFIGURED
> fi
> 
> After a cleanup of a started resource the variable
> OCF_RESKEY_CRM_meta_notify_start_uname is empty. A simple and quick
> solution would be to add "stop" to the following block in a case
> switch:
> 
> case $__OCF_ACTION in
> monitor|validate-all)
> :;;
> 
> This is line 778 in the Resource Agent. In my opinion it does not
> make much sense to make the "is notify enabled" check when stopping
> a resource. Hence it seems reasonable to exclude a stop action from
> this check.
> 
> Is there something that speaks against it? If not, I will send a
> patch to this list.


Thanks,
but that should be fixed already:
http://git.drbd.org/?p=drbd-8.3.git;a=shortlog

Always first check git...

-- 
: Lars Ellenberg
: LINBIT | Your Way to High Availability
: DRBD/HA support and consulting http://www.linbit.com

DRBD® and LINBIT® are registered trademarks of LINBIT, Austria.