[Drbd-dev] [PATCH] drbd-utils: drbd service: specifying commands from /sbin/ with absolute path

[Drbd-dev] [PATCH] drbd-utils: drbd service: specifying commands from /sbin/ with absolute path

[Imre Palik]

From: "Palik, Imre" <imrep@amazon.de>

This change removes the dependance of the service on wether /sbin is
in the path or not.

Signed-off-by: Imre Palik <imrep@amazon.de>
---
 scripts/drbd |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/scripts/drbd b/scripts/drbd
index b6b0a2c..482c69d 100755
--- a/scripts/drbd
+++ b/scripts/drbd
@@ -27,6 +27,8 @@ DRBDSETUP="drbdsetup"
 PROC_DRBD="/proc/drbd"
 MODPROBE="/sbin/modprobe"
 RMMOD="/sbin/rmmod"
+UDEVADM="/sbin/udevadm"
+UDEVSETTLE="/sbin/udevsettle"
 UDEV_TIMEOUT=10
 ADD_MOD_PARAM=""
 
@@ -120,13 +122,13 @@ drbd_pretty_status()
 # But don't wait too long.
 _udev_settle()
 {
-	if udevadm version ; then
+	if $UDEVADM version ; then
 		# ok, we have udevadm, use it.
-		udevadm settle --timeout=5
+		$UDEVADM settle --timeout=5
 	else
 		# if udevsettle is not there,
 		# no matter.
-		udevsettle --timeout=5
+		$UDEVSETTLE --timeout=5
 	fi
 }
 
-- 
1.7.9.5

Re: [Drbd-dev] [PATCH] drbd-utils: drbd service: specifying commands from /sbin/ with absolute path

[Lars Ellenberg]

On Mon, Feb 09, 2015 at 02:05:38PM +0100, Imre Palik wrote:
> From: "Palik, Imre" <imrep@amazon.de>
> 
> This change removes the dependance of the service on wether /sbin is
> in the path or not.

If you are NOT root,
this will not work anyways.

If you ARE root,
/sbin (or your local equivalent) is supposed to be in your path.

There are deployments out there
that have these tools not in /sbin but elsewhere. 

	Lars