From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: Shailendra Verma <shailendra.capricorn@gmail.com>
Cc: linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH] block:drbd:drbd_receiver - Change 1/0 to true/false for bool type variable rv in function overlapping_resync_write().
Date: Wed, 27 May 2015 11:31:36 +0200 [thread overview]
Message-ID: <20150527093136.GJ18767@soda.linbit> (raw)
In-Reply-To: <1432584909-5349-1-git-send-email-shailendra.capricorn@gmail.com>
On Tue, May 26, 2015 at 01:45:09AM +0530, Shailendra Verma wrote:
> In function overlapping_resync_write() variable rv is bool type.
> Hence assigning the values as true/false instead of 1/0.
I like 0 and 1 better. So unless the powers that be rule this to be the
recommended or mandatory coding style, I consider this just noise.
Lars
> - bool rv = 0;
> + bool rv = false;
> - rv = 1;
> + rv = true;
prev parent reply other threads:[~2015-05-27 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 20:15 [Drbd-dev] [PATCH] block:drbd:drbd_receiver - Change 1/0 to true/false for bool type variable rv in function overlapping_resync_write() Shailendra Verma
2015-05-27 9:31 ` Lars Ellenberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527093136.GJ18767@soda.linbit \
--to=lars.ellenberg@linbit.com \
--cc=drbd-dev@lists.linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shailendra.capricorn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox