[Drbd-dev] [PATCH] block:drbd:drbd_receiver - Change 1/0 to true/false for bool type variable rv in function overlapping_resync_write().

[Drbd-dev] [PATCH] block:drbd:drbd_receiver - Change 1/0 to true/false for bool type variable rv in function overlapping_resync_write().

[Shailendra Verma]

In function overlapping_resync_write() variable rv is bool type.
Hence assigning the values as true/false instead of 1/0.

Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
---
 drivers/block/drbd/drbd_receiver.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index cee2035..78cc75f 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -2038,13 +2038,13 @@ static inline int overlaps(sector_t s1, int l1, sector_t s2, int l2)
 static bool overlapping_resync_write(struct drbd_device *device, struct drbd_peer_request *peer_req)
 {
 	struct drbd_peer_request *rs_req;
-	bool rv = 0;
+	bool rv = false;
 
 	spin_lock_irq(&device->resource->req_lock);
 	list_for_each_entry(rs_req, &device->sync_ee, w.list) {
 		if (overlaps(peer_req->i.sector, peer_req->i.size,
 			     rs_req->i.sector, rs_req->i.size)) {
-			rv = 1;
+			rv = true;
 			break;
 		}
 	}
-- 
1.7.9.5

Re: [Drbd-dev] [PATCH] block:drbd:drbd_receiver - Change 1/0 to true/false for bool type variable rv in function overlapping_resync_write().

[Lars Ellenberg]

On Tue, May 26, 2015 at 01:45:09AM +0530, Shailendra Verma wrote:
> In function overlapping_resync_write() variable rv is bool type.
> Hence assigning the values as true/false instead of 1/0.

I like 0 and 1 better.  So unless the powers that be rule this to be the
recommended or mandatory coding style, I consider this just noise.

    Lars

> -	bool rv = 0;
> +	bool rv = false;

> -			rv = 1;
> +			rv = true;