From: Jason Gunthorpe <jgg@ziepe.ca>
To: Christoph Hellwig <hch@lst.de>
Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Eric Dumazet <edumazet@google.com>,
linux-nvme@lists.infradead.org, linux-sctp@vger.kernel.org,
target-devel@vger.kernel.org, linux-afs@lists.infradead.org,
drbd-dev@lists.linbit.com, linux-cifs@vger.kernel.org,
rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org,
cluster-devel@redhat.com, Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
linux-block@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org,
Neil Horman <nhorman@tuxdriver.com>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
netdev@vger.kernel.org, Vlad Yasevich <vyasevich@gmail.com>,
linux-kernel@vger.kernel.org, Jon Maloy <jmaloy@redhat.com>,
Ying Xue <ying.xue@windriver.com>,
"David S. Miller" <davem@davemloft.net>,
ocfs2-devel@oss.oracle.com
Subject: Re: [Drbd-dev] [PATCH 11/33] tcp: tcp_sock_set_nodelay
Date: Sat, 13 Jun 2020 09:58:45 -0000 [thread overview]
Message-ID: <20200513125144.GC29989@ziepe.ca> (raw)
In-Reply-To: <20200513062649.2100053-12-hch@lst.de>
On Wed, May 13, 2020 at 08:26:26AM +0200, Christoph Hellwig wrote:
> Add a helper to directly set the TCP_NODELAY sockopt from kernel space
> without going through a fake uaccess. Cleanup the callers to avoid
> pointless wrappers now that this is a simple function call.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/block/drbd/drbd_int.h | 7 ----
> drivers/block/drbd/drbd_main.c | 2 +-
> drivers/block/drbd/drbd_receiver.c | 4 +--
> drivers/infiniband/sw/siw/siw_cm.c | 24 +++-----------
> drivers/nvme/host/tcp.c | 9 +-----
> drivers/nvme/target/tcp.c | 12 ++-----
> drivers/target/iscsi/iscsi_target_login.c | 15 ++-------
> fs/cifs/connect.c | 10 ++----
> fs/dlm/lowcomms.c | 8 ++---
> fs/ocfs2/cluster/tcp.c | 20 ++----------
> include/linux/tcp.h | 1 +
> net/ceph/messenger.c | 11 ++-----
> net/ipv4/tcp.c | 39 +++++++++++++++--------
> net/rds/tcp.c | 11 +------
> net/rds/tcp.h | 1 -
> net/rds/tcp_listen.c | 2 +-
> 16 files changed, 49 insertions(+), 127 deletions(-)
No problem with the siw change
Acked-by: Jason Gunthorpe <jgg@mellanox.com>
Jason
next prev parent reply other threads:[~2020-06-13 9:56 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 6:26 [Drbd-dev] remove kernel_setsockopt and kernel_getsockopt Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 01/33] net: add sock_set_reuseaddr Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 02/33] net: add sock_set_linger Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 03/33] net: add sock_set_priority Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 04/33] net: add sock_set_sndtimeo Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 05/33] net: add sock_bindtoindex Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 06/33] net: add sock_set_timestamps Christoph Hellwig
2020-06-13 10:00 ` David Howells
2020-05-13 6:26 ` [Drbd-dev] [PATCH 07/33] net: add sock_set_keepalive Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 08/33] net: add sock_set_rcvbuf Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 09/33] net: add sock_set_reuseport Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 10/33] tcp: add tcp_sock_set_cork Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 11/33] tcp: tcp_sock_set_nodelay Christoph Hellwig
2020-06-13 9:58 ` Jason Gunthorpe [this message]
2020-05-13 6:26 ` [Drbd-dev] [PATCH 12/33] tcp: add tcp_sock_set_quickack Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 13/33] tcp: add tcp_sock_set_syncnt Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 14/33] tcp: add tcp_sock_set_user_timeout Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 15/33] tcp: add tcp_sock_set_keepidle Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 16/33] tcp: add tcp_sock_set_keepintvl Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 17/33] tcp: add tcp_sock_set_keepcnt Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 18/33] ipv4: add ip_sock_set_tos Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 19/33] ipv4: add ip_sock_set_freebind Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 20/33] ipv4: add ip_sock_set_recverr Christoph Hellwig
2020-05-13 21:00 ` Joe Perches
2020-05-14 10:30 ` Christoph Hellwig
2020-05-14 11:51 ` Joe Perches
2020-05-20 14:18 ` Christoph Hellwig
2020-06-13 10:00 ` David Howells
2020-05-13 6:26 ` [Drbd-dev] [PATCH 21/33] ipv4: add ip_sock_set_mtu_discover Christoph Hellwig
2020-06-13 9:59 ` David Howells
2020-05-14 6:26 ` Christoph Hellwig
2020-06-13 10:10 ` David Howells
2020-05-13 6:26 ` [Drbd-dev] [PATCH 22/33] ipv6: add ip6_sock_set_v6only Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 23/33] ipv6: add ip6_sock_set_recverr Christoph Hellwig
2020-06-13 10:01 ` David Howells
2020-05-13 6:26 ` [Drbd-dev] [PATCH 24/33] ipv6: add ip6_sock_set_addr_preferences Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 25/33] ipv6: add ip6_sock_set_recvpktinfo Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 26/33] sctp: lift copying in addrs into sctp_setsockopt Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 27/33] sctp: export sctp_setsockopt_bindx Christoph Hellwig
2020-06-13 10:01 ` Marcelo Ricardo Leitner
2020-05-14 6:28 ` Christoph Hellwig
2020-06-13 10:11 ` David Howells
2020-05-15 15:24 ` Christoph Hellwig
2020-06-13 10:12 ` David Laight
2020-06-13 10:11 ` David Laight
2020-06-13 10:12 ` [Drbd-dev] [Ocfs2-devel] " Matthew Wilcox
2020-06-13 10:13 ` David Laight
2020-05-14 10:40 ` [Drbd-dev] is it ok to always pull in sctp for dlm, was: " Christoph Hellwig
2020-06-13 10:07 ` David Teigland
2020-06-13 10:04 ` [Drbd-dev] " David Laight
2020-05-13 6:26 ` [Drbd-dev] [PATCH 28/33] sctp: add sctp_sock_set_nodelay Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 29/33] rxrpc_sock_set_min_security_level Christoph Hellwig
2020-06-13 9:59 ` David Howells
2020-05-14 10:29 ` Christoph Hellwig
2020-06-13 10:10 ` David Howells
2020-05-13 6:26 ` [Drbd-dev] [PATCH 30/33] tipc: call tsk_set_importance from tipc_topsrv_create_listener Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 31/33] net: remove kernel_setsockopt Christoph Hellwig
2020-05-13 6:26 ` [Drbd-dev] [PATCH 32/33] sctp: add sctp_sock_get_primary_addr Christoph Hellwig
2020-06-13 10:02 ` Marcelo Ricardo Leitner
2020-06-13 10:05 ` David Laight
2020-06-13 10:06 ` David Laight
2020-06-13 10:07 ` David Laight
2020-05-13 6:26 ` [Drbd-dev] [PATCH 33/33] net: remove kernel_getsockopt Christoph Hellwig
2020-05-13 17:38 ` [Drbd-dev] remove kernel_setsockopt and kernel_getsockopt Joe Perches
2020-05-14 6:27 ` Christoph Hellwig
2020-06-13 10:04 ` David Laight
2020-05-14 10:18 ` Christoph Hellwig
2020-06-13 10:05 ` David Laight
2020-05-14 10:34 ` 'Christoph Hellwig'
2020-06-13 10:06 ` David Laight
2020-06-13 10:08 ` [Drbd-dev] [Ocfs2-devel] " Matthew Wilcox
2020-06-13 10:09 ` [Drbd-dev] " David Miller
2020-06-13 10:09 ` David Laight
2020-06-13 10:08 ` David Miller
2020-06-13 10:03 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513125144.GC29989@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=ceph-devel@vger.kernel.org \
--cc=cluster-devel@redhat.com \
--cc=davem@davemloft.net \
--cc=drbd-dev@lists.linbit.com \
--cc=edumazet@google.com \
--cc=hch@lst.de \
--cc=jmaloy@redhat.com \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-afs@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=rds-devel@oss.oracle.com \
--cc=target-devel@vger.kernel.org \
--cc=vyasevich@gmail.com \
--cc=ying.xue@windriver.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox