From: Lukas Wunner <lukas@wunner.de>
To: Elimar Riesebieter <riesebie@lxtec.de>
Cc: Michael Hierweck <michael.hierweck@hostsharing.net>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH drbd-9.0] compat: __vmalloc() pgprot argument was removed in v5.8
Date: Sun, 11 Oct 2020 20:55:45 +0200 [thread overview]
Message-ID: <20201011185545.GB18543@wunner.de> (raw)
In-Reply-To: <20201011184741.c766frixh5v7xgyb@toy.home.lxtec.de>
On Sun, Oct 11, 2020 at 08:47:41PM +0200, Elimar Riesebieter wrote:
> * Elimar Riesebieter <riesebie@lxtec.de> [2020-10-11 20:39 +0200]:
> > /var/lib/dkms/drbd/9.0.25-1hsh2/build/src/drbd/drbd_bitmap.c: In function "bm_realloc_pages":
> > /var/lib/dkms/drbd/9.0.25-1hsh2/build/src/drbd/drbd_bitmap.c:368:15: error: too few arguments to function "__vmalloc"
>
> This was on 4.19. I think the changes must depend on KVERS as the
> modules should build from 4.19 upwards. Will try your patch against
> 5.8 tomorrow.
The patch tests whether __vmalloc() expects 2 arguments and applies
the coccinelle patch if not. The coccinelle patch adds the third
argument to the __vmalloc() invocation. This works independently
of the specific kernel version.
Thanks,
Lukas
next prev parent reply other threads:[~2020-10-12 15:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 16:07 [Drbd-dev] [PATCH drbd-9.0] compat: __vmalloc() pgprot argument was removed in v5.8 Lukas Wunner
2020-10-11 18:39 ` Elimar Riesebieter
2020-10-11 18:47 ` Elimar Riesebieter
2020-10-11 18:55 ` Lukas Wunner [this message]
2020-10-11 18:51 ` Lukas Wunner
2020-10-11 19:20 ` Elimar Riesebieter
2020-10-11 19:30 ` Elimar Riesebieter
2020-10-12 0:54 ` Lukas Wunner
2020-10-12 11:14 ` Elimar Riesebieter
2020-10-23 7:23 ` Lukas Wunner
2020-10-12 10:57 ` Elimar Riesebieter
2020-10-20 14:06 ` Christoph Böhmwalder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201011185545.GB18543@wunner.de \
--to=lukas@wunner.de \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=michael.hierweck@hostsharing.net \
--cc=philipp.reisner@linbit.com \
--cc=riesebie@lxtec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox