Distributed Replicated Block Device (DRBD) development
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Elimar Riesebieter <riesebie@lxtec.de>
Cc: Michael Hierweck <michael.hierweck@hostsharing.net>,
	Lars Ellenberg <lars.ellenberg@linbit.com>,
	Philipp Reisner <philipp.reisner@linbit.com>,
	drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH drbd-9.0] compat: __vmalloc() pgprot argument was removed in v5.8
Date: Fri, 23 Oct 2020 09:23:12 +0200	[thread overview]
Message-ID: <20201023072312.GA14966@wunner.de> (raw)
In-Reply-To: <20201012111439.jyewfvopfsjeyvp3@toy.home.lxtec.de>

Hi Elimar,

my apologies for the delay.

On Mon, Oct 12, 2020 at 01:14:39PM +0200, Elimar Riesebieter wrote:
> * Lukas Wunner <lukas@wunner.de> [2020-10-12 02:54 +0200]:
> > If you're unsuccessful debugging the build failure on your own,
> > maybe you can upload your drbd build directory somewhere so I
> > can take a look.
> 
> https://lxtec.de/drbd/drbd_dkms_buildir_hsh_201012.tar.xz

If coccinelle is not available, drbd-kernel-compat/gen_compat_patch.sh
attempts to fetch the coccinelle-generated patch from the cloud by
sending a POST request to https://drbd.io:2020/api/v1/spatch/9.0.25-1
with the locally-generated compat.h.

Because the cloud service generates the patch for the release version
9.0.25-1 and not for your locally-patched source, you end up with a
patch which doesn't work.

The solution is to disable usage of the cloud service by setting the
environment variable SPAAS=false and adding coccinelle >= 1.0.8 to
the drbd-dkms package's prerequisites.  It's not safe to use the
cloud service if you apply custom patches to the source code.

I was unable to reproduce the issue because I built from the git repo
and gen_compat_patch.sh never uses the cloud service in that case.

HTH,

Lukas

  reply	other threads:[~2020-10-23  7:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-11 16:07 [Drbd-dev] [PATCH drbd-9.0] compat: __vmalloc() pgprot argument was removed in v5.8 Lukas Wunner
2020-10-11 18:39 ` Elimar Riesebieter
2020-10-11 18:47   ` Elimar Riesebieter
2020-10-11 18:55     ` Lukas Wunner
2020-10-11 18:51   ` Lukas Wunner
2020-10-11 19:20     ` Elimar Riesebieter
2020-10-11 19:30     ` Elimar Riesebieter
2020-10-12  0:54       ` Lukas Wunner
2020-10-12 11:14         ` Elimar Riesebieter
2020-10-23  7:23           ` Lukas Wunner [this message]
2020-10-12 10:57 ` Elimar Riesebieter
2020-10-20 14:06 ` Christoph Böhmwalder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201023072312.GA14966@wunner.de \
    --to=lukas@wunner.de \
    --cc=drbd-dev@lists.linbit.com \
    --cc=lars.ellenberg@linbit.com \
    --cc=michael.hierweck@hostsharing.net \
    --cc=philipp.reisner@linbit.com \
    --cc=riesebie@lxtec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox