[Drbd-dev] [patch 1/1] drivers/block/drbd/drbd_nl.c: use bitmap_parse instead of __bitmap_parse

[Drbd-dev] [patch 1/1] drivers/block/drbd/drbd_nl.c: use bitmap_parse instead of __bitmap_parse

[akpm]

From: H Hartley Sweeten <hartleys@visionengravers.com>

The buffer 'sc.cpu_mask' is a kernel buffer.  If bitmap_parse is used
instead of __bitmap_parse the extra parameter that indicates a kernel
buffer is not needed.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Lars Ellenberg <drbd-dev@lists.linbit.com>
Cc: Philipp Reisner <philipp.reisner@linbit.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/block/drbd/drbd_nl.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff -puN drivers/block/drbd/drbd_nl.c~drivers-block-drbd-drbd_nlc-use-bitmap_parse-instead-of-__bitmap_parse drivers/block/drbd/drbd_nl.c
--- a/drivers/block/drbd/drbd_nl.c~drivers-block-drbd-drbd_nlc-use-bitmap_parse-instead-of-__bitmap_parse
+++ a/drivers/block/drbd/drbd_nl.c
@@ -1829,10 +1829,10 @@ static int drbd_nl_syncer_conf(struct dr
 
 	/* silently ignore cpu mask on UP kernel */
 	if (nr_cpu_ids > 1 && sc.cpu_mask[0] != 0) {
-		err = __bitmap_parse(sc.cpu_mask, 32, 0,
+		err = bitmap_parse(sc.cpu_mask, 32,
 				cpumask_bits(new_cpu_mask), nr_cpu_ids);
 		if (err) {
-			dev_warn(DEV, "__bitmap_parse() failed with %d\n", err);
+			dev_warn(DEV, "bitmap_parse() failed with %d\n", err);
 			retcode = ERR_CPU_MASK_PARSE;
 			goto fail;
 		}
_

Re: [Drbd-dev] [patch 1/1] drivers/block/drbd/drbd_nl.c: use bitmap_parse instead of __bitmap_parse

[Jens Axboe]

On 2011-07-28 22:52, akpm@linux-foundation.org wrote:
> From: H Hartley Sweeten <hartleys@visionengravers.com>
> 
> The buffer 'sc.cpu_mask' is a kernel buffer.  If bitmap_parse is used
> instead of __bitmap_parse the extra parameter that indicates a kernel
> buffer is not needed.

Applied, thanks.

-- 
Jens Axboe