From: Aaron Conole <aconole@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: axboe@kernel.dk, dev@openvswitch.org, jiri@resnulli.us,
netdev@vger.kernel.org, jacob.e.keller@intel.com,
philipp.reisner@linbit.com, jmaloy@redhat.com,
linux-block@vger.kernel.org, edumazet@google.com,
tipc-discussion@lists.sourceforge.net, lars.ellenberg@linbit.com,
Jiri Pirko <jiri@nvidia.com>,
ying.xue@windriver.com, johannes@sipsolutions.net,
pabeni@redhat.com, davem@davemloft.net,
drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [ovs-dev] [PATCH net-next v3 03/10] genetlink: remove userhdr from struct genl_info
Date: Tue, 15 Aug 2023 08:49:08 -0400 [thread overview]
Message-ID: <f7twmxwxygr.fsf@redhat.com> (raw)
In-Reply-To: <20230814214723.2924989-4-kuba@kernel.org> (Jakub Kicinski's message of "Mon, 14 Aug 2023 14:47:16 -0700")
Jakub Kicinski <kuba@kernel.org> writes:
> Only three families use info->userhdr today and going forward
> we discourage using fixed headers in new families.
> So having the pointer to user header in struct genl_info
> is an overkill. Compute the header pointer at runtime.
>
> Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
Seems the OVS side didn't change from v2 so still:
Reviewed-by: Aaron Conole <aconole@redhat.com>
prev parent reply other threads:[~2023-08-15 12:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230814214723.2924989-1-kuba@kernel.org>
2023-08-14 21:47 ` [Drbd-dev] [PATCH net-next v3 03/10] genetlink: remove userhdr from struct genl_info Jakub Kicinski
2023-08-15 12:49 ` Aaron Conole [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7twmxwxygr.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=drbd-dev@lists.linbit.com \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=jmaloy@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=philipp.reisner@linbit.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox