From: Thomas Hellstrom <thellstrom@vmware.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
linux-graphics-maintainer <linux-graphics-maintainer@vmware.com>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 05/21] drm/vmwgfx: Remove confused comment from vmw_du_connector_atomic_set_property
Date: Fri, 5 Oct 2018 18:19:44 +0000 [thread overview]
Message-ID: <0da6c35d-28fa-0c0e-c3b6-6fb5427c0089@vmware.com> (raw)
In-Reply-To: <20181005074840.GZ31561@phenom.ffwll.local>
On 10/05/2018 09:48 AM, Daniel Vetter wrote:
> On Fri, Oct 05, 2018 at 08:43:51AM +0200, Daniel Vetter wrote:
>> On Thu, Oct 04, 2018 at 10:40:16PM +0000, Thomas Hellstrom wrote:
>>> Hi!
>>>
>>> I've sent out patches that replace 05/21 and 07/21. Since I'm on travel,
>>> I'm not sure I'll be able to incorporate them in a pull before the merge
>>> window though.
>> is_implicit is taken care of with those indeed. But patch 07 seems still
>> needed, at least I'm not seeing where you remove the custom page_flip
>> checks.
> Clarification, now that coffee kicks in: I wrote the FIXME comments since
> an atomic driver should not have _any_ checks in its page_flip callback
> beyond what the helper does. Only thing you can do in there is fix up uapi
> inconsistency, because your driver-specific does something funky. Like in
> your set_config callback, where you clear a parameter that old versions of
> vmwgfx userspace don't clear.
>
> So end result for addressing patch 07 is that you directly put the helper
> function into the vtable. You removed a bunch of checks, but there's still
> a bit left.
Ah, are you referring to the stdu->defined check? I think that's just a
leftover sanity check that I can remove. Or were you referring to
something else?
/Thomas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-10-05 18:19 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 20:24 [PATCH 00/21] atomic helper cleanup, take 2 Daniel Vetter
2018-10-04 20:24 ` [PATCH 01/21] drm/amdgpu: Remove default best_encoder hook from DC Daniel Vetter
2018-10-05 15:41 ` Harry Wentland
2018-10-05 20:13 ` Leo Li
2018-10-04 20:24 ` [PATCH 02/21] drm/atomic-helper: Unexport drm_atomic_helper_best_encoder Daniel Vetter
2018-10-04 20:24 ` [PATCH 03/21] drm: Extract drm_atomic_state_helper.[hc] Daniel Vetter
2018-10-04 20:24 ` [PATCH 04/21] drm/vmwgfx: Don't look at state->allow_modeset Daniel Vetter
2018-10-04 20:24 ` [PATCH 05/21] drm/vmwgfx: Remove confused comment from vmw_du_connector_atomic_set_property Daniel Vetter
2018-10-04 22:40 ` Thomas Hellstrom
2018-10-05 6:43 ` Daniel Vetter
2018-10-05 7:48 ` Daniel Vetter
2018-10-05 18:19 ` Thomas Hellstrom [this message]
2018-10-05 18:30 ` Daniel Vetter
2018-10-04 20:24 ` [PATCH 06/21] drm/atomic: Improve docs for drm_atomic_state->allow_modeset Daniel Vetter
2018-10-04 20:24 ` [PATCH 07/21] drm/vmwgfx: Add FIXME comments for customer page_flip handlers Daniel Vetter
2018-10-04 20:24 ` [PATCH 08/21] drm/arcpgu: Drop transitional hooks Daniel Vetter
2018-10-04 20:24 ` [PATCH 09/21] drm/atmel: " Daniel Vetter
2018-10-04 20:24 ` [PATCH 10/21] drm/arcpgu: Use drm_atomic_helper_shutdown Daniel Vetter
[not found] ` <20181004202446.22905-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2018-10-04 20:24 ` [PATCH 11/21] drm/msm: " Daniel Vetter
2018-10-04 20:24 ` [PATCH 12/21] drm/sti: " Daniel Vetter
2018-10-04 20:24 ` [PATCH 13/21] drm/vc4: " Daniel Vetter
2018-10-04 20:24 ` [PATCH 14/21] drm/zte: " Daniel Vetter
2018-10-05 13:07 ` Shawn Guo
2018-10-04 20:24 ` [PATCH 15/21] drm: Remove transitional helpers Daniel Vetter
2018-10-04 21:04 ` Sam Ravnborg
2018-10-05 6:10 ` Daniel Vetter
2018-10-04 20:24 ` [PATCH 16/21] drm/vmwgfx: Fix vmw_du_cursor_plane_atomic_check Daniel Vetter
2018-10-05 16:06 ` Daniel Vetter
2018-10-05 16:21 ` Thomas Hellstrom
2018-10-05 20:46 ` Daniel Vetter
2018-10-05 20:53 ` Thomas Hellstrom
2018-10-04 20:24 ` [PATCH 17/21] drm: Unexport drm_plane_helper_check_update Daniel Vetter
2018-10-04 21:03 ` Sam Ravnborg
2018-10-05 6:13 ` Daniel Vetter
2018-10-04 20:24 ` [PATCH 18/21] drm: Unexport primary plane helpers Daniel Vetter
2018-10-04 21:14 ` Sam Ravnborg
2018-10-05 6:18 ` Daniel Vetter
2018-10-05 9:47 ` [PATCH] " Daniel Vetter
2018-10-04 20:24 ` [PATCH 19/21] drm/doc: fix drm_driver_legacy_fb_format Daniel Vetter
2018-10-05 5:07 ` Gerd Hoffmann
2018-10-04 20:24 ` [PATCH 20/21] drm/todo: Add some cleanup tasks Daniel Vetter
2018-10-04 20:35 ` Ville Syrjälä
2018-10-05 16:07 ` Harry Wentland
2018-10-05 16:20 ` Eric Engestrom
2018-10-04 20:24 ` [PATCH 21/21] drm/doc: kerneldoc for quirk_addfb_prefer_xbgr_30bpp Daniel Vetter
2018-10-24 10:01 ` Alexandru-Cosmin Gheorghe
2018-10-24 12:19 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0da6c35d-28fa-0c0e-c3b6-6fb5427c0089@vmware.com \
--to=thellstrom@vmware.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-graphics-maintainer@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox