Re: [PATCH 01/24] drm/vblank: Unexport drm_wait_one_vblank()

[Thomas Zimmermann <tzimmermann@suse.de>]

Am 10.11.25 um 17:17 schrieb Jani Nikula:
> From: Thomas Zimmermann <tzimmermann@suse.de>
>
> Make drm_wait_on_vblank() static. The function is an internal interface
> and not invoked directly by drivers.

I forgot about that patch. Thanks for picking it up.

>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>   drivers/gpu/drm/drm_vblank.c | 14 +-------------
>   include/drm/drm_vblank.h     |  1 -
>   2 files changed, 1 insertion(+), 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
> index 32d013c5c8fc..c15d6d9d0082 100644
> --- a/drivers/gpu/drm/drm_vblank.c
> +++ b/drivers/gpu/drm/drm_vblank.c
> @@ -1286,18 +1286,7 @@ void drm_crtc_vblank_put(struct drm_crtc *crtc)
>   }
>   EXPORT_SYMBOL(drm_crtc_vblank_put);
>   
> -/**
> - * drm_wait_one_vblank - wait for one vblank
> - * @dev: DRM device
> - * @pipe: CRTC index
> - *
> - * This waits for one vblank to pass on @pipe, using the irq driver interfaces.
> - * It is a failure to call this when the vblank irq for @pipe is disabled, e.g.
> - * due to lack of driver support or because the crtc is off.
> - *
> - * This is the legacy version of drm_crtc_wait_one_vblank().
> - */
> -void drm_wait_one_vblank(struct drm_device *dev, unsigned int pipe)
> +static void drm_wait_one_vblank(struct drm_device *dev, unsigned int pipe)
>   {
>   	struct drm_vblank_crtc *vblank = drm_vblank_crtc(dev, pipe);
>   	int ret;
> @@ -1321,7 +1310,6 @@ void drm_wait_one_vblank(struct drm_device *dev, unsigned int pipe)
>   
>   	drm_vblank_put(dev, pipe);
>   }
> -EXPORT_SYMBOL(drm_wait_one_vblank);
>   
>   /**
>    * drm_crtc_wait_one_vblank - wait for one vblank
> diff --git a/include/drm/drm_vblank.h b/include/drm/drm_vblank.h
> index ffa564d79638..94ee09b48895 100644
> --- a/include/drm/drm_vblank.h
> +++ b/include/drm/drm_vblank.h
> @@ -302,7 +302,6 @@ bool drm_handle_vblank(struct drm_device *dev, unsigned int pipe);
>   bool drm_crtc_handle_vblank(struct drm_crtc *crtc);
>   int drm_crtc_vblank_get(struct drm_crtc *crtc);
>   void drm_crtc_vblank_put(struct drm_crtc *crtc);
> -void drm_wait_one_vblank(struct drm_device *dev, unsigned int pipe);
>   void drm_crtc_wait_one_vblank(struct drm_crtc *crtc);
>   void drm_crtc_vblank_off(struct drm_crtc *crtc);
>   void drm_crtc_vblank_reset(struct drm_crtc *crtc);

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)