Re: [PATCH 18/24] drm/vblank: add drm_crtc_from_vblank() helper

[Thomas Zimmermann <tzimmermann@suse.de>]

Am 10.11.25 um 17:17 schrieb Jani Nikula:
> We have a handful of places where we need to get the crtc from the
> vblank. Add a small helper for it.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

Maybe not strictly necessary.

> ---
>   drivers/gpu/drm/drm_vblank.c | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
> index 64cd96207ad5..34d0b6939d52 100644
> --- a/drivers/gpu/drm/drm_vblank.c
> +++ b/drivers/gpu/drm/drm_vblank.c
> @@ -188,6 +188,11 @@ drm_crtc_vblank_crtc(struct drm_crtc *crtc)
>   }
>   EXPORT_SYMBOL(drm_crtc_vblank_crtc);
>   
> +static struct drm_crtc *drm_crtc_from_vblank(struct drm_vblank_crtc *vblank)
> +{
> +	return drm_crtc_from_index(vblank->dev, vblank->pipe);
> +}
> +
>   static void store_vblank(struct drm_vblank_crtc *vblank,
>   			 u32 vblank_count_inc,
>   			 ktime_t t_vblank, u32 last)
> @@ -1605,7 +1610,7 @@ static int drm_queue_vblank_event(struct drm_vblank_crtc *vblank,
>   	e->event.vbl.user_data = vblwait->request.signal;
>   	e->event.vbl.crtc_id = 0;
>   	if (drm_core_check_feature(dev, DRIVER_MODESET)) {
> -		struct drm_crtc *crtc = drm_crtc_from_index(dev, pipe);
> +		struct drm_crtc *crtc = drm_crtc_from_vblank(vblank);
>   
>   		if (crtc)
>   			e->event.vbl.crtc_id = crtc->base.id;
> @@ -1855,7 +1860,7 @@ static void drm_handle_vblank_events(struct drm_vblank_crtc *vblank)
>   {
>   	struct drm_device *dev = vblank->dev;
>   	unsigned int pipe = vblank->pipe;
> -	struct drm_crtc *crtc = drm_crtc_from_index(dev, pipe);
> +	struct drm_crtc *crtc = drm_crtc_from_vblank(vblank);
>   	bool high_prec = false;
>   	struct drm_pending_vblank_event *e, *t;
>   	ktime_t now;

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)