From: "Kazlauskas, Nicholas" <Nicholas.Kazlauskas@amd.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
Pekka Paalanen <pekka.paalanen@collabora.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 3/3] drm/doc: fix VRR_ENABLED casing
Date: Wed, 30 Jan 2019 16:57:48 +0000 [thread overview]
Message-ID: <1294f446-fd1c-8b4b-5ff2-12d60f5b19de@amd.com> (raw)
In-Reply-To: <20190130163006.28945-3-daniel.vetter@ffwll.ch>
On 1/30/19 11:30 AM, Daniel Vetter wrote:
> Yes it's inconsitent with vrr_capable, but this is the actual uapi as
> exercise by igt.
>
> Fixes: ab7a664f7a2d ("drm: Document variable refresh properties")
> Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Pekka Paalanen <pekka.paalanen@collabora.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
It's what xf86-video-amdgpu expects too - the casing is intentional to
match up with the other default CRTC properties.
Thanks!
Nicholas Kazlauskas
> ---
> drivers/gpu/drm/drm_connector.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index 847539645558..e3ff73695c32 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -1367,7 +1367,7 @@ EXPORT_SYMBOL(drm_mode_create_scaling_mode_property);
> *
> * Absence of the property should indicate absence of support.
> *
> - * "vrr_enabled":
> + * "VRR_ENABLED":
> * Default &drm_crtc boolean property that notifies the driver that the
> * content on the CRTC is suitable for variable refresh rate presentation.
> * The driver will take this property as a hint to enable variable
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-01-30 16:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 16:30 [PATCH 1/3] drm/doc: Move hdmi infoframe docs Daniel Vetter
2019-01-30 16:30 ` [PATCH 2/3] drm/doc: Drop chapter "KMS Initialization and Cleanup" Daniel Vetter
2019-01-30 17:33 ` Kazlauskas, Nicholas
2019-01-30 21:02 ` Daniel Vetter
2019-01-30 21:04 ` Kazlauskas, Nicholas
2019-01-30 21:16 ` Daniel Vetter
2019-01-30 16:30 ` [PATCH 3/3] drm/doc: fix VRR_ENABLED casing Daniel Vetter
2019-01-30 16:57 ` Kazlauskas, Nicholas [this message]
2019-01-30 16:59 ` Daniel Vetter
2019-01-30 17:13 ` [PATCH 1/3] drm/doc: Move hdmi infoframe docs Kazlauskas, Nicholas
2019-01-30 21:17 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294f446-fd1c-8b4b-5ff2-12d60f5b19de@amd.com \
--to=nicholas.kazlauskas@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=pekka.paalanen@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox