From: Daniel Vetter <daniel@ffwll.ch>
To: "Kazlauskas, Nicholas" <Nicholas.Kazlauskas@amd.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 1/3] drm/doc: Move hdmi infoframe docs
Date: Wed, 30 Jan 2019 22:17:56 +0100 [thread overview]
Message-ID: <20190130211756.GP3271@phenom.ffwll.local> (raw)
In-Reply-To: <70f4cca6-84e4-16a5-15df-cc6724b16cf1@amd.com>
On Wed, Jan 30, 2019 at 05:13:13PM +0000, Kazlauskas, Nicholas wrote:
> On 1/30/19 11:30 AM, Daniel Vetter wrote:
> > .. next to all the other sink helpers. The rect library is more used
> > for handling plane clipping, so belongs to those imo.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>
> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>
> Looks better than being sandwiched between the HDMI helpers. Flip work
> is also plane related in a sense.
Yup, that's what I meant with plane helpers - the kms helper intro groups
all these (flip, plane helpers, rect stuff, ...) into a plane related
helpers pile.
Thanks for taking a look, patch merged.
-Daniel
>
> Nicholas Kazlauskas
>
> > ---
> > Documentation/gpu/drm-kms-helpers.rst | 24 ++++++++++++------------
> > 1 file changed, 12 insertions(+), 12 deletions(-)
> >
> > diff --git a/Documentation/gpu/drm-kms-helpers.rst b/Documentation/gpu/drm-kms-helpers.rst
> > index fbd11b2fe5b5..17ca7f8bf3d3 100644
> > --- a/Documentation/gpu/drm-kms-helpers.rst
> > +++ b/Documentation/gpu/drm-kms-helpers.rst
> > @@ -296,18 +296,6 @@ SCDC Helper Functions Reference
> > .. kernel-doc:: drivers/gpu/drm/drm_scdc_helper.c
> > :export:
> >
> > -Rectangle Utilities Reference
> > -=============================
> > -
> > -.. kernel-doc:: include/drm/drm_rect.h
> > - :doc: rect utils
> > -
> > -.. kernel-doc:: include/drm/drm_rect.h
> > - :internal:
> > -
> > -.. kernel-doc:: drivers/gpu/drm/drm_rect.c
> > - :export:
> > -
> > HDMI Infoframes Helper Reference
> > ================================
> >
> > @@ -322,6 +310,18 @@ libraries and hence is also included here.
> > .. kernel-doc:: drivers/video/hdmi.c
> > :export:
> >
> > +Rectangle Utilities Reference
> > +=============================
> > +
> > +.. kernel-doc:: include/drm/drm_rect.h
> > + :doc: rect utils
> > +
> > +.. kernel-doc:: include/drm/drm_rect.h
> > + :internal:
> > +
> > +.. kernel-doc:: drivers/gpu/drm/drm_rect.c
> > + :export:
> > +
> > Flip-work Helper Reference
> > ==========================
> >
> >
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-01-30 21:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 16:30 [PATCH 1/3] drm/doc: Move hdmi infoframe docs Daniel Vetter
2019-01-30 16:30 ` [PATCH 2/3] drm/doc: Drop chapter "KMS Initialization and Cleanup" Daniel Vetter
2019-01-30 17:33 ` Kazlauskas, Nicholas
2019-01-30 21:02 ` Daniel Vetter
2019-01-30 21:04 ` Kazlauskas, Nicholas
2019-01-30 21:16 ` Daniel Vetter
2019-01-30 16:30 ` [PATCH 3/3] drm/doc: fix VRR_ENABLED casing Daniel Vetter
2019-01-30 16:57 ` Kazlauskas, Nicholas
2019-01-30 16:59 ` Daniel Vetter
2019-01-30 17:13 ` [PATCH 1/3] drm/doc: Move hdmi infoframe docs Kazlauskas, Nicholas
2019-01-30 21:17 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130211756.GP3271@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Nicholas.Kazlauskas@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox