From: "Michel Dänzer" <michel@daenzer.net>
To: Ilija Hadzic <ihadzic@research.bell-labs.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] kernel/drm: vblank wait on crtc > 1
Date: Tue, 22 Mar 2011 12:12:04 +0100 [thread overview]
Message-ID: <1300792324.3476.23.camel@thor.local> (raw)
In-Reply-To: <Pine.GSO.4.62.1103181553130.13846@umail>
On Fre, 2011-03-18 at 16:58 -0500, Ilija Hadzic wrote:
>
> This patch extends the interface to drm_wait_vblank ioctl so that crtc>1
> can be represented. It also adds a new capability to drm_getcap ioctl so
> that the user space can check whether the new interface to drm_wait_vblank
> is supported (and fall back to the legacy interface if not)
[...]
You seem to have silently ignored my previous concerns and suggestions
about the handling of the high CRTC mask/shift.
> @@ -753,6 +755,7 @@ struct drm_event_vblank {
> };
>
> #define DRM_CAP_DUMB_BUFFER 0x1
> +#define DRM_CAP_HIGH_CRTC 0x2
Seems like a rather generic name, something like
DRM_CAP_VBLANK_HIGH_CRTC might be better.
--
Earthling Michel Dänzer | http://www.vmware.com
Libre software enthusiast | Debian, X and DRI developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2011-03-22 11:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 21:58 [PATCH] kernel/drm: vblank wait on crtc > 1 Ilija Hadzic
2011-03-18 22:07 ` Jesse Barnes
2011-03-18 23:13 ` Ilija Hadzic
2011-03-18 23:34 ` Jesse Barnes
2011-03-19 19:35 ` Alex Deucher
2011-03-20 17:32 ` Ilija Hadzic
2011-03-19 20:16 ` Alex Deucher
2011-03-20 23:24 ` Dave Airlie
2011-03-20 23:47 ` Ilija Hadzic
2011-03-21 21:55 ` OT: sending patches to the list (was: [PATCH] kernel/drm: vblank wait on crtc > 1) Paul Menzel
2011-03-22 11:12 ` Michel Dänzer [this message]
2011-03-22 11:16 ` [PATCH] kernel/drm: vblank wait on crtc > 1 Ilija Hadzic
2011-03-22 11:27 ` Michel Dänzer
2011-03-22 13:43 ` Ilija Hadzic
2011-03-22 14:45 ` Michel Dänzer
-- strict thread matches above, loose matches on Subject: below --
2011-03-19 17:30 Mario Kleiner
2011-03-19 18:12 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300792324.3476.23.camel@thor.local \
--to=michel@daenzer.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=ihadzic@research.bell-labs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox