From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Ilija Hadzic <ihadzic@research.bell-labs.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] kernel/drm: vblank wait on crtc > 1
Date: Fri, 18 Mar 2011 16:34:23 -0700 [thread overview]
Message-ID: <20110318163423.3b32fdc2@jbarnes-desktop> (raw)
In-Reply-To: <Pine.GSO.4.62.1103181811180.1021@umail>
On Fri, 18 Mar 2011 18:13:11 -0500 (CDT)
Ilija Hadzic <ihadzic@research.bell-labs.com> wrote:
>
>
> On Fri, 18 Mar 2011, Jesse Barnes wrote:
>
> >
> > I like the new param check, but I'd still prefer a new ioctl to abusing
> > the old one.
> >
>
> It's not "abusing" it but extending the interface in a
> backwards-compatible manner. Introducing a new one would result in two
> ioctls that essentially do the same thing, which I don't like.
Yes abusing was a strong word; I just don't like encoding crtc numbers
in a bitfield, when we just use ints everywhere else.
Not a big deal, Dave will make the final call. Thanks for doing this
work.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2011-03-18 23:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 21:58 [PATCH] kernel/drm: vblank wait on crtc > 1 Ilija Hadzic
2011-03-18 22:07 ` Jesse Barnes
2011-03-18 23:13 ` Ilija Hadzic
2011-03-18 23:34 ` Jesse Barnes [this message]
2011-03-19 19:35 ` Alex Deucher
2011-03-20 17:32 ` Ilija Hadzic
2011-03-19 20:16 ` Alex Deucher
2011-03-20 23:24 ` Dave Airlie
2011-03-20 23:47 ` Ilija Hadzic
2011-03-21 21:55 ` OT: sending patches to the list (was: [PATCH] kernel/drm: vblank wait on crtc > 1) Paul Menzel
2011-03-22 11:12 ` [PATCH] kernel/drm: vblank wait on crtc > 1 Michel Dänzer
2011-03-22 11:16 ` Ilija Hadzic
2011-03-22 11:27 ` Michel Dänzer
2011-03-22 13:43 ` Ilija Hadzic
2011-03-22 14:45 ` Michel Dänzer
-- strict thread matches above, loose matches on Subject: below --
2011-03-19 17:30 Mario Kleiner
2011-03-19 18:12 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110318163423.3b32fdc2@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ihadzic@research.bell-labs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).