* [PATCH] drm/radeon/kms: fix i2c map for rv250/280
@ 2011-07-23 18:02 alexdeucher
2011-08-03 9:21 ` Thierry Vignaud
0 siblings, 1 reply; 2+ messages in thread
From: alexdeucher @ 2011-07-23 18:02 UTC (permalink / raw)
To: airlied, dri-devel; +Cc: Alex Deucher, stable
From: Alex Deucher <alexander.deucher@amd.com>
Those chips have crt2_ddc bus.
Fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=39672
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@kernel.org
---
drivers/gpu/drm/radeon/radeon_combios.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_combios.c b/drivers/gpu/drm/radeon/radeon_combios.c
index e459467..a74217c 100644
--- a/drivers/gpu/drm/radeon/radeon_combios.c
+++ b/drivers/gpu/drm/radeon/radeon_combios.c
@@ -779,7 +779,8 @@ void radeon_combios_i2c_init(struct radeon_device *rdev)
}
}
}
- } else if (rdev->family >= CHIP_R200) {
+ } else if ((rdev->family == CHIP_R200) ||
+ (rdev->family >= CHIP_R300)) {
/* 0x68 */
i2c = combios_setup_i2c_bus(rdev, DDC_MONID, 0, 0);
rdev->i2c_bus[3] = radeon_i2c_create(dev, &i2c, "MONID");
--
1.7.1.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/radeon/kms: fix i2c map for rv250/280
2011-07-23 18:02 [PATCH] drm/radeon/kms: fix i2c map for rv250/280 alexdeucher
@ 2011-08-03 9:21 ` Thierry Vignaud
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Vignaud @ 2011-08-03 9:21 UTC (permalink / raw)
To: alexdeucher; +Cc: Alex Deucher, stable, dri-devel
On 23 July 2011 20:02, <alexdeucher@gmail.com> wrote:
> From: Alex Deucher <alexander.deucher@amd.com>
>
> Those chips have crt2_ddc bus.
Maybe adding a comment in the code'll make sure nobody will ever "clean up" or
"optimize" the tests by replacing them back by "else if (rdev->family
>= CHIP_R200)"...
> - } else if (rdev->family >= CHIP_R200) {
> + } else if ((rdev->family == CHIP_R200) ||
> + (rdev->family >= CHIP_R300)) {
> /* 0x68 */
> i2c = combios_setup_i2c_bus(rdev, DDC_MONID, 0, 0);
> rdev->i2c_bus[3] = radeon_i2c_create(dev, &i2c, "MONID");
My 2 cents
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-03 9:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-23 18:02 [PATCH] drm/radeon/kms: fix i2c map for rv250/280 alexdeucher
2011-08-03 9:21 ` Thierry Vignaud
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox