From: "Michel Dänzer" <michel@daenzer.net>
To: Dave Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: introduce drm_can_sleep and use in intel/radeon drivers.
Date: Thu, 05 Jan 2012 11:11:45 +0100 [thread overview]
Message-ID: <1325758305.1807.537.camel@thor.local> (raw)
In-Reply-To: <1325757476-19469-1-git-send-email-airlied@gmail.com>
On Don, 2012-01-05 at 09:57 +0000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> So we have a few places where the drm drivers would like to sleep to
> be nice to the system, mainly in the modesetting paths, but we also
> have two cases were atomic modesetting must take place, panic writing
> and kernel debugger. So provide a central inline to determine if a
> sleep or delay should be used and use this in the intel and radeon drivers.
>
> Based on patch from Michel Dänzer <michel.daenzer@amd.com>
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=43941
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> ---
> drivers/gpu/drm/i915/intel_drv.h | 4 ++--
> drivers/gpu/drm/radeon/atom.c | 2 ++
> include/drm/drmP.h | 8 ++++++++
> 3 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> index a1b4343..cf2326b 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
[...]
> @@ -48,7 +48,7 @@
> #define wait_for_atomic(COND, MS) _wait_for(COND, MS, 0)
>
> #define MSLEEP(x) do { \
> - if (in_dbg_master()) \
> + if (!drm_can_sleeep()) \
> mdelay(x); \
So for MSLEEP it's not enough if it can sleep, it has to be able to
'sleeep'? ;) Looks like this macro is unused.
Looks good to me otherwise, thanks.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Debian, X and DRI developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2012-01-05 10:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 9:57 [PATCH] drm: introduce drm_can_sleep and use in intel/radeon drivers Dave Airlie
2012-01-05 10:11 ` Michel Dänzer [this message]
2012-01-05 16:00 ` Daniel Vetter
2012-01-05 16:10 ` Chris Wilson
2012-01-06 10:04 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325758305.1807.537.camel@thor.local \
--to=michel@daenzer.net \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox