dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Dave Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: introduce drm_can_sleep and use in intel/radeon drivers.
Date: Thu, 5 Jan 2012 17:00:52 +0100	[thread overview]
Message-ID: <20120105160051.GE3831@phenom.ffwll.local> (raw)
In-Reply-To: <1325757476-19469-1-git-send-email-airlied@gmail.com>

On Thu, Jan 05, 2012 at 09:57:56AM +0000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
> 
> So we have a few places where the drm drivers would like to sleep to
> be nice to the system, mainly in the modesetting paths, but we also
> have two cases were atomic modesetting must take place, panic writing
> and kernel debugger. So provide a central inline to determine if a
> sleep or delay should be used and use this in the intel and radeon drivers.
> 
> Based on patch from Michel Dänzer <michel.daenzer@amd.com>
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=43941
> 
> Signed-off-by: Dave Airlie <airlied@redhat.com>

If MSLEEP is indeed unused, I think it should just die - we have way too
much yelling cruft from dri1 yonder lying around that hides important
details like this. Otherwise

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48

  parent reply	other threads:[~2012-01-05 15:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-05  9:57 [PATCH] drm: introduce drm_can_sleep and use in intel/radeon drivers Dave Airlie
2012-01-05 10:11 ` Michel Dänzer
2012-01-05 16:00 ` Daniel Vetter [this message]
2012-01-05 16:10   ` Chris Wilson
2012-01-06 10:04   ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120105160051.GE3831@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox