dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Etheridge <detheridge@ti.com>
To: detheridge@ti.com, robdclark@gmail.com, airlied@linux.ie,
	linux@arm.linux.org.uk, sebastian.hesselbarth@gmail.com
Cc: dri-devel@lists.freedesktop.org
Subject: [PATCH 0/2] drm/tilcdc drm/i2c/tda998x workaround for sync issues on TI SoC
Date: Thu, 25 Jul 2013 13:32:16 -0500	[thread overview]
Message-ID: <1374777138-22567-1-git-send-email-detheridge@ti.com> (raw)

Russell King and Sebastian Hasselbarth had proposed some very good changes
for the tda998x HDMI encoder driver.  But when those changes were tested
on BeagleBone Black against the tilcdc driver many modes would no longer
display correctly.  After analyzing the sync signals from the TI lcd contoller
to the nxp it is apparent that the hsync/vsync's are not rising at the same 
time as per the VESA spec and this is causing the HDMI encoder to get 
messed up and failing to lock correctly.

This series of patches should be applied on top of:

Russell King's
rmk's Dove DRM/TDA19988 Cubox driver series

Sebastian Hasselbarth's
drm/i2c: tda998x: fix sync generation and calculation

I have done as much of the change as I can in the tilcdc driver but there 
is a small unavoidable change in the tda998x driver.  However I have been 
careful not to break anything from the Dove drivers perspective. It 
would be great if somebody can test on Cubox and confirm that.

This patch set inverts the hsync signal coming from the tilcdc so the NXP 
is kept happy and then shifts the output to the right to compensate for the 
sync timing issues.  Display modes from the NXP have been verified using a
HDMI analyzer and are reporting correct timings at the output stage.

Hopefully this will allow the dove/tda driver changes to progress now that
were blocked as per this discussion:
http://lists.freedesktop.org/archives/dri-devel/2013-July/040900.html


Darren Etheridge (2):
  drm/i2c/tda998x prepare for tilcdc sync workaround
  drm/tilcdc fixup mode to workaound sync for tda998x

 drivers/gpu/drm/i2c/tda998x_drv.c     |   10 ++++++++++
 drivers/gpu/drm/tilcdc/tilcdc_crtc.c  |    7 ++++++-
 drivers/gpu/drm/tilcdc/tilcdc_slave.c |   21 ++++++++++++++++++++-
 3 files changed, 36 insertions(+), 2 deletions(-)

             reply	other threads:[~2013-07-25 18:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 18:32 Darren Etheridge [this message]
2013-07-25 18:32 ` [PATCH 1/2] drm/i2c/tda998x prepare for tilcdc sync workaround Darren Etheridge
2013-07-25 18:32 ` [PATCH 2/2] drm/tilcdc fixup mode to workaound sync for tda998x Darren Etheridge
2013-07-25 19:32 ` [PATCH 0/2] drm/tilcdc drm/i2c/tda998x workaround for sync issues on TI SoC Rob Clark
2013-07-30  7:36   ` Sebastian Hesselbarth
2013-07-31 20:21   ` Sebastian Hesselbarth
2013-07-31 20:28     ` Russell King - ARM Linux
2013-08-01 14:29     ` Darren Etheridge
2013-08-01 15:19       ` Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374777138-22567-1-git-send-email-detheridge@ti.com \
    --to=detheridge@ti.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux@arm.linux.org.uk \
    --cc=robdclark@gmail.com \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox