dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Etheridge <detheridge@ti.com>
To: detheridge@ti.com, robdclark@gmail.com, airlied@linux.ie,
	linux@arm.linux.org.uk, sebastian.hesselbarth@gmail.com
Cc: dri-devel@lists.freedesktop.org
Subject: [PATCH 1/2] drm/i2c/tda998x prepare for tilcdc sync workaround
Date: Thu, 25 Jul 2013 13:32:17 -0500	[thread overview]
Message-ID: <1374777138-22567-2-git-send-email-detheridge@ti.com> (raw)
In-Reply-To: <1374777138-22567-1-git-send-email-detheridge@ti.com>

Add necessary support for flipping the hsync signal and shifting
the display to the right by a certain number of pixels.  Changes
only take effect if adjusted_mode is changed in fixup function.

Signed-off-by: Darren Etheridge <detheridge@ti.com>
---
 drivers/gpu/drm/i2c/tda998x_drv.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index e384b59..ad870e6 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -778,6 +778,16 @@ tda998x_encoder_mode_set(struct drm_encoder *encoder,
 	n_line       = mode->vtotal;
 
 	ref_pix      = 3 + mode->hsync_start - mode->hdisplay;
+
+	/*
+	 * handle issue on TILCDC where it is outputing
+	 * non-VESA compliant sync signals the workaround
+	 * forces us to invert the HSYNC, so need to adjust display to
+	 * the left by hskew pixels, provided by the tilcdc driver
+	 */
+	if (adjusted_mode->flags & DRM_MODE_FLAG_HSKEW)
+		ref_pix += adjusted_mode->hskew;
+
 	de_pix_s     = mode->htotal - mode->hdisplay;
 	de_pix_e     = de_pix_s + mode->hdisplay;
 	hs_pix_s     = mode->hsync_start - mode->hdisplay;
-- 
1.7.0.4

  reply	other threads:[~2013-07-25 18:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 18:32 [PATCH 0/2] drm/tilcdc drm/i2c/tda998x workaround for sync issues on TI SoC Darren Etheridge
2013-07-25 18:32 ` Darren Etheridge [this message]
2013-07-25 18:32 ` [PATCH 2/2] drm/tilcdc fixup mode to workaound sync for tda998x Darren Etheridge
2013-07-25 19:32 ` [PATCH 0/2] drm/tilcdc drm/i2c/tda998x workaround for sync issues on TI SoC Rob Clark
2013-07-30  7:36   ` Sebastian Hesselbarth
2013-07-31 20:21   ` Sebastian Hesselbarth
2013-07-31 20:28     ` Russell King - ARM Linux
2013-08-01 14:29     ` Darren Etheridge
2013-08-01 15:19       ` Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374777138-22567-2-git-send-email-detheridge@ti.com \
    --to=detheridge@ti.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux@arm.linux.org.uk \
    --cc=robdclark@gmail.com \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox