* [PATCH edid-decode 1/3] Add a missing comma to the list of CEA VICs
@ 2013-09-27 11:26 Thomas Wood
2013-09-27 11:27 ` [PATCH edid-decode 2/3] Include the last VIC in the CEA video block Thomas Wood
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Thomas Wood @ 2013-09-27 11:26 UTC (permalink / raw)
To: dri-devel
Signed-off-by: Thomas Wood <thomas.wood@intel.com>
---
edid-decode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edid-decode.c b/edid-decode.c
index d3e3118..3830e0c 100644
--- a/edid-decode.c
+++ b/edid-decode.c
@@ -649,7 +649,7 @@ static const char *edid_cea_modes[] = {
"1440x240@60Hz",
"1440x240@60Hz",
"2880x480i@60Hz",
- "2880x480i@60Hz"
+ "2880x480i@60Hz",
"2880x240@60Hz",
"2880x240@60Hz",
"1440x480@60Hz",
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH edid-decode 2/3] Include the last VIC in the CEA video block
2013-09-27 11:26 [PATCH edid-decode 1/3] Add a missing comma to the list of CEA VICs Thomas Wood
@ 2013-09-27 11:27 ` Thomas Wood
2013-09-27 11:27 ` [PATCH edid-decode 3/3] Print the correct VIC number next to the mode Thomas Wood
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Thomas Wood @ 2013-09-27 11:27 UTC (permalink / raw)
To: dri-devel
Signed-off-by: Thomas Wood <thomas.wood@intel.com>
---
edid-decode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edid-decode.c b/edid-decode.c
index 3830e0c..b710bb5 100644
--- a/edid-decode.c
+++ b/edid-decode.c
@@ -711,7 +711,7 @@ cea_video_block(unsigned char *x)
int i;
int length = x[0] & 0x1f;
- for (i = 1; i < length; i++) {
+ for (i = 1; i <= length; i++) {
unsigned char vic = x[i] & 0x7f;
unsigned char native = x[i] & 0x80;
const char *mode;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH edid-decode 3/3] Print the correct VIC number next to the mode
2013-09-27 11:26 [PATCH edid-decode 1/3] Add a missing comma to the list of CEA VICs Thomas Wood
2013-09-27 11:27 ` [PATCH edid-decode 2/3] Include the last VIC in the CEA video block Thomas Wood
@ 2013-09-27 11:27 ` Thomas Wood
2013-09-27 12:35 ` [PATCH edid-decode 1/3] Add a missing comma to the list of CEA VICs Damien Lespiau
2013-09-27 14:06 ` Damien Lespiau
3 siblings, 0 replies; 5+ messages in thread
From: Thomas Wood @ 2013-09-27 11:27 UTC (permalink / raw)
To: dri-devel
Signed-off-by: Thomas Wood <thomas.wood@intel.com>
---
edid-decode.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/edid-decode.c b/edid-decode.c
index b710bb5..4265843 100644
--- a/edid-decode.c
+++ b/edid-decode.c
@@ -715,10 +715,11 @@ cea_video_block(unsigned char *x)
unsigned char vic = x[i] & 0x7f;
unsigned char native = x[i] & 0x80;
const char *mode;
+ int index;
- vic--;
- if (vic < ARRAY_SIZE(edid_cea_modes))
- mode = edid_cea_modes[vic];
+ index = vic - 1;
+ if (index < ARRAY_SIZE(edid_cea_modes))
+ mode = edid_cea_modes[index];
else
mode = "Unknown mode";
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH edid-decode 1/3] Add a missing comma to the list of CEA VICs
2013-09-27 11:26 [PATCH edid-decode 1/3] Add a missing comma to the list of CEA VICs Thomas Wood
2013-09-27 11:27 ` [PATCH edid-decode 2/3] Include the last VIC in the CEA video block Thomas Wood
2013-09-27 11:27 ` [PATCH edid-decode 3/3] Print the correct VIC number next to the mode Thomas Wood
@ 2013-09-27 12:35 ` Damien Lespiau
2013-09-27 14:06 ` Damien Lespiau
3 siblings, 0 replies; 5+ messages in thread
From: Damien Lespiau @ 2013-09-27 12:35 UTC (permalink / raw)
To: Thomas Wood; +Cc: dri-devel
On Fri, Sep 27, 2013 at 12:26:59PM +0100, Thomas Wood wrote:
> Signed-off-by: Thomas Wood <thomas.wood@intel.com>
For the series (that fixes 2 embarassing bugs from me and 1 long
standing one that wasn't parsing the last CEA VIC):
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
--
Damien
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH edid-decode 1/3] Add a missing comma to the list of CEA VICs
2013-09-27 11:26 [PATCH edid-decode 1/3] Add a missing comma to the list of CEA VICs Thomas Wood
` (2 preceding siblings ...)
2013-09-27 12:35 ` [PATCH edid-decode 1/3] Add a missing comma to the list of CEA VICs Damien Lespiau
@ 2013-09-27 14:06 ` Damien Lespiau
3 siblings, 0 replies; 5+ messages in thread
From: Damien Lespiau @ 2013-09-27 14:06 UTC (permalink / raw)
To: Thomas Wood; +Cc: dri-devel
On Fri, Sep 27, 2013 at 12:26:59PM +0100, Thomas Wood wrote:
> Signed-off-by: Thomas Wood <thomas.wood@intel.com>
Thanks for the series, all pushed with the virtual nod from Ajax on
IRC.
--
Damien
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-27 14:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-27 11:26 [PATCH edid-decode 1/3] Add a missing comma to the list of CEA VICs Thomas Wood
2013-09-27 11:27 ` [PATCH edid-decode 2/3] Include the last VIC in the CEA video block Thomas Wood
2013-09-27 11:27 ` [PATCH edid-decode 3/3] Print the correct VIC number next to the mode Thomas Wood
2013-09-27 12:35 ` [PATCH edid-decode 1/3] Add a missing comma to the list of CEA VICs Damien Lespiau
2013-09-27 14:06 ` Damien Lespiau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox