dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Subject: [PATCH 01/19] drm/rcar: call drm_put_dev directly in the ->remove hook
Date: Sun,  3 Nov 2013 14:31:07 +0100	[thread overview]
Message-ID: <1383485485-8210-2-git-send-email-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <1383485485-8210-1-git-send-email-daniel.vetter@ffwll.ch>

The magic dance drm_platform_exit does is actually a remnant of the
old legacy shadow attach support for platform devices. Modern modesetting
drm drivers shouldn't do this any more (and usb/pci devices actually don't
do this).

Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/rcar-du/rcar_du_drv.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index 0023f9719cf1..4ec6272a1c11 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -224,7 +224,9 @@ static int rcar_du_probe(struct platform_device *pdev)
 
 static int rcar_du_remove(struct platform_device *pdev)
 {
-	drm_platform_exit(&rcar_du_driver, pdev);
+	struct rcar_du_device *rcdu = platform_get_drvdata(pdev);
+
+	drm_put_dev(rcdu->ddev);
 
 	return 0;
 }
-- 
1.8.4.rc3

  reply	other threads:[~2013-11-03 13:31 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-03 13:31 [PATCH 00/19] drm de-midlayer, part 1: device list and agp bus stuff Daniel Vetter
2013-11-03 13:31 ` Daniel Vetter [this message]
2013-11-03 13:47   ` [PATCH 01/19] drm/rcar: call drm_put_dev directly in the ->remove hook Laurent Pinchart
2013-11-03 13:31 ` [PATCH 02/19] drm/exynos: call drm_put_dev directly from ->remove Daniel Vetter
2013-11-03 13:31 ` [PATCH 03/19] drm/imx: directly call drm_put_dev in ->remove Daniel Vetter
2013-11-04  8:19   ` Sascha Hauer
2013-11-03 13:31 ` [PATCH 04/19] drm/tilcdc: call drm_put_dev directly from ->remove Daniel Vetter
2013-11-03 13:31 ` [PATCH 05/19] drm/omap: call drm_put_dev directly in ->remove Daniel Vetter
2013-11-03 13:31 ` [PATCH 06/19] drm/shmob: call drm_put_dev directly from ->remove hook Daniel Vetter
2013-11-03 13:31 ` [PATCH 07/19] drm/host1x: Call drm_put_dev directly instead of drm_platform_exit Daniel Vetter
2013-11-04  9:10   ` Thierry Reding
2013-11-04  9:13     ` Thierry Reding
2013-11-04 10:14     ` Daniel Vetter
2013-11-04 10:51       ` Thierry Reding
2013-11-03 13:31 ` [PATCH 08/19] drm/armada: directly call drm_put_dev in ->remove Daniel Vetter
2013-11-03 13:31 ` [PATCH 09/19] drm/msm: call drm_put_dev directly " Daniel Vetter
2013-11-03 13:31 ` [PATCH 10/19] drm: rip out drm_platform_exit Daniel Vetter
2013-11-03 13:31 ` [PATCH 11/19] drm: restrict the device list for shadow attached drivers Daniel Vetter
2013-11-03 14:05   ` David Herrmann
2013-11-03 14:14     ` Daniel Vetter
2013-11-03 18:51       ` [PATCH] " Daniel Vetter
2013-11-04  9:20       ` [PATCH 11/19] " Thierry Reding
2013-11-03 13:31 ` [PATCH 12/19] drm/bufs: remove handling of _DRM_GEM mappings Daniel Vetter
2013-11-03 14:06   ` David Herrmann
2013-11-03 13:31 ` [PATCH 13/19] drm: kill DRIVER_REQUIRE_AGP Daniel Vetter
2013-11-03 13:31 ` [PATCH 14/19] drm: ->agp_init can't fail Daniel Vetter
2013-11-03 14:12   ` David Herrmann
2013-11-03 13:31 ` [PATCH 15/19] drm: rip out drm_core_has_AGP Daniel Vetter
2013-11-03 13:31 ` [PATCH 16/19] drm: remove agp_init() bus callback Daniel Vetter
2013-11-03 14:14   ` David Herrmann
2013-11-03 14:20     ` Daniel Vetter
2013-11-03 14:42       ` [PATCH] " Daniel Vetter
2013-11-03 13:31 ` [PATCH 17/19] drm: inline drm_agp_destroy Daniel Vetter
2013-11-03 13:43   ` David Herrmann
2013-11-03 14:36     ` Daniel Vetter
2013-11-03 13:31 ` [PATCH 18/19] drm: kill the ->agp_destroy callback Daniel Vetter
2013-11-03 13:49   ` David Herrmann
2013-11-03 14:24     ` [PATCH] " Daniel Vetter
2013-11-03 14:34       ` David Herrmann
2013-11-03 17:32         ` Daniel Vetter
2013-11-03 13:31 ` [PATCH 19/19] drm: remove global_mutex locking around agp_init Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383485485-8210-2-git-send-email-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox