Re: [PATCH 03/19] drm/imx: directly call drm_put_dev in ->remove

[Sascha Hauer <s.hauer@pengutronix.de>]

On Sun, Nov 03, 2013 at 02:31:09PM +0100, Daniel Vetter wrote:
> Again no apparent user of the driver data field.
> 
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

Sascha

> ---
>  drivers/staging/imx-drm/imx-drm-core.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c
> index c1014eb2907d..8ffd4a900bb9 100644
> --- a/drivers/staging/imx-drm/imx-drm-core.c
> +++ b/drivers/staging/imx-drm/imx-drm-core.c
> @@ -432,6 +432,8 @@ static int imx_drm_driver_load(struct drm_device *drm, unsigned long flags)
>  	if (!imx_drm_device_get())
>  		ret = -EINVAL;
>  
> +	platform_set_drvdata(drm->platformdev, drm);
> +
>  	ret = 0;
>  
>  err_init:
> @@ -807,7 +809,7 @@ static int imx_drm_platform_probe(struct platform_device *pdev)
>  
>  static int imx_drm_platform_remove(struct platform_device *pdev)
>  {
> -	drm_platform_exit(&imx_drm_driver, pdev);
> +	drm_put_dev(platform_get_drvdata(pdev));
>  
>  	return 0;
>  }
> -- 
> 1.8.4.rc3
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |