* [PATCH 1/2] drm/ast: open key before detect chips
@ 2014-09-10 4:07 Y.C. Chen
2014-09-10 4:07 ` [PATCH 2/2] drm/ast: AST2000 cannot be detected correctly Y.C. Chen
2014-09-10 8:34 ` [PATCH 1/2] drm/ast: open key before detect chips Egbert Eich
0 siblings, 2 replies; 4+ messages in thread
From: Y.C. Chen @ 2014-09-10 4:07 UTC (permalink / raw)
To: dri-devel; +Cc: eich, yc_chen, airlied
From: "Y.C. Chen" <yc_chen@aspeedtech.com>
Some config settings like 3rd TX chips will not get correctly
if the extended reg is protected
Signed-off-by: Y.C. Chen <yc_chen@aspeedtech.com>
---
drivers/gpu/drm/ast/ast_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c
index a2cc6be..b027e33 100644
--- a/drivers/gpu/drm/ast/ast_main.c
+++ b/drivers/gpu/drm/ast/ast_main.c
@@ -67,6 +67,7 @@ static int ast_detect_chip(struct drm_device *dev)
{
struct ast_private *ast = dev->dev_private;
uint32_t data, jreg;
+ ast_open_key(ast);
if (dev->pdev->device == PCI_CHIP_AST1180) {
ast->chip = AST1100;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] drm/ast: AST2000 cannot be detected correctly
2014-09-10 4:07 [PATCH 1/2] drm/ast: open key before detect chips Y.C. Chen
@ 2014-09-10 4:07 ` Y.C. Chen
2014-09-10 8:35 ` Egbert Eich
2014-09-10 8:34 ` [PATCH 1/2] drm/ast: open key before detect chips Egbert Eich
1 sibling, 1 reply; 4+ messages in thread
From: Y.C. Chen @ 2014-09-10 4:07 UTC (permalink / raw)
To: dri-devel; +Cc: eich, yc_chen, airlied
From: "Y.C. Chen" <yc_chen@aspeedtech.com>
Type error and cause AST2000 cannot be detected correctly
Signed-off-by: Y.C. Chen <yc_chen@aspeedtech.com>
---
drivers/gpu/drm/ast/ast_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c
index b027e33..b792194 100644
--- a/drivers/gpu/drm/ast/ast_main.c
+++ b/drivers/gpu/drm/ast/ast_main.c
@@ -105,7 +105,7 @@ static int ast_detect_chip(struct drm_device *dev)
}
ast->vga2_clone = false;
} else {
- ast->chip = 2000;
+ ast->chip = AST2000;
DRM_INFO("AST 2000 detected\n");
}
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] drm/ast: open key before detect chips
2014-09-10 4:07 [PATCH 1/2] drm/ast: open key before detect chips Y.C. Chen
2014-09-10 4:07 ` [PATCH 2/2] drm/ast: AST2000 cannot be detected correctly Y.C. Chen
@ 2014-09-10 8:34 ` Egbert Eich
1 sibling, 0 replies; 4+ messages in thread
From: Egbert Eich @ 2014-09-10 8:34 UTC (permalink / raw)
To: Y.C. Chen; +Cc: eich, dri-devel, airlied
Y.C. Chen writes:
> From: "Y.C. Chen" <yc_chen@aspeedtech.com>
>
> Some config settings like 3rd TX chips will not get correctly
> if the extended reg is protected
>
> Signed-off-by: Y.C. Chen <yc_chen@aspeedtech.com>
> ---
> drivers/gpu/drm/ast/ast_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c
> index a2cc6be..b027e33 100644
> --- a/drivers/gpu/drm/ast/ast_main.c
> +++ b/drivers/gpu/drm/ast/ast_main.c
> @@ -67,6 +67,7 @@ static int ast_detect_chip(struct drm_device *dev)
> {
> struct ast_private *ast = dev->dev_private;
> uint32_t data, jreg;
> + ast_open_key(ast);
>
> if (dev->pdev->device == PCI_CHIP_AST1180) {
> ast->chip = AST1100;
> --
> 1.8.3.1
>
Reviewed-by: Egbert Eich <eich@suse.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] drm/ast: AST2000 cannot be detected correctly
2014-09-10 4:07 ` [PATCH 2/2] drm/ast: AST2000 cannot be detected correctly Y.C. Chen
@ 2014-09-10 8:35 ` Egbert Eich
0 siblings, 0 replies; 4+ messages in thread
From: Egbert Eich @ 2014-09-10 8:35 UTC (permalink / raw)
To: Y.C. Chen; +Cc: eich, dri-devel, airlied
Y.C. Chen writes:
> From: "Y.C. Chen" <yc_chen@aspeedtech.com>
>
> Type error and cause AST2000 cannot be detected correctly
>
> Signed-off-by: Y.C. Chen <yc_chen@aspeedtech.com>
> ---
> drivers/gpu/drm/ast/ast_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c
> index b027e33..b792194 100644
> --- a/drivers/gpu/drm/ast/ast_main.c
> +++ b/drivers/gpu/drm/ast/ast_main.c
> @@ -105,7 +105,7 @@ static int ast_detect_chip(struct drm_device *dev)
> }
> ast->vga2_clone = false;
> } else {
> - ast->chip = 2000;
> + ast->chip = AST2000;
> DRM_INFO("AST 2000 detected\n");
> }
> }
> --
> 1.8.3.1
>
Reviewed-by: Egbert Eich <eich@suse.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-10 8:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-10 4:07 [PATCH 1/2] drm/ast: open key before detect chips Y.C. Chen
2014-09-10 4:07 ` [PATCH 2/2] drm/ast: AST2000 cannot be detected correctly Y.C. Chen
2014-09-10 8:35 ` Egbert Eich
2014-09-10 8:34 ` [PATCH 1/2] drm/ast: open key before detect chips Egbert Eich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox