From: Philipp Zabel <p.zabel@pengutronix.de>
To: slongerbeam@gmail.com
Cc: Steve Longerbeam <steve_longerbeam@mentor.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 5/6] imx-drm: encoder mode_set must use adjusted mode
Date: Wed, 17 Dec 2014 15:03:03 +0100 [thread overview]
Message-ID: <1418824983.3155.45.camel@pengutronix.de> (raw)
In-Reply-To: <1418689764-11276-6-git-send-email-slongerbeam@gmail.com>
Am Montag, den 15.12.2014, 16:29 -0800 schrieb slongerbeam@gmail.com:
> From: Steve Longerbeam <steve_longerbeam@mentor.com>
>
> The encoder ->mode_set() methods need to use the hw adjusted mode,
> not the original mode.
>
> Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>
> ---
> drivers/gpu/drm/imx/imx-hdmi.c | 4 ++--
> drivers/gpu/drm/imx/imx-ldb.c | 4 ++--
> drivers/gpu/drm/imx/imx-tve.c | 4 ++--
> drivers/gpu/drm/imx/parallel-display.c | 4 ++--
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/imx-hdmi.c b/drivers/gpu/drm/imx/imx-hdmi.c
> index aaec6b2..32116cc 100644
> --- a/drivers/gpu/drm/imx/imx-hdmi.c
> +++ b/drivers/gpu/drm/imx/imx-hdmi.c
> @@ -1417,8 +1417,8 @@ static struct drm_encoder *imx_hdmi_connector_best_encoder(struct drm_connector
> }
>
> static void imx_hdmi_encoder_mode_set(struct drm_encoder *encoder,
> - struct drm_display_mode *mode,
> - struct drm_display_mode *adjusted_mode)
> + struct drm_display_mode *orig_mode,
> + struct drm_display_mode *mode)
> {
> struct imx_hdmi *hdmi = container_of(encoder, struct imx_hdmi, encoder);
>
> diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c
> index 4662e00..a88c0e1 100644
> --- a/drivers/gpu/drm/imx/imx-ldb.c
> +++ b/drivers/gpu/drm/imx/imx-ldb.c
There's another line that should be changed
- struct drm_display_mode *mode = &encoder->crtc->mode;
+ struct drm_display_mode *mode = &encoder->crtc->hwmode;
in imx_ldb_encoder_prepare.
> @@ -246,8 +246,8 @@ static void imx_ldb_encoder_commit(struct drm_encoder *encoder)
> }
>
> static void imx_ldb_encoder_mode_set(struct drm_encoder *encoder,
> - struct drm_display_mode *mode,
> - struct drm_display_mode *adjusted_mode)
> + struct drm_display_mode *orig_mode,
> + struct drm_display_mode *mode)
> {
> struct imx_ldb_channel *imx_ldb_ch = enc_to_imx_ldb_ch(encoder);
> struct imx_ldb *ldb = imx_ldb_ch->ldb;
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-12-17 14:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 0:29 [PATCH 0/6] imx-drm: ipuv3-crtc: Implement mode_fixup slongerbeam
2014-12-16 0:29 ` [PATCH 1/6] gpu: ipu-di: Add ipu_di_adjust_videomode() slongerbeam
2014-12-17 12:27 ` Fabio Estevam
2014-12-18 19:05 ` Steve Longerbeam
2014-12-16 0:29 ` [PATCH 2/6] gpu: ipu-di: remove some non-functional code slongerbeam
2014-12-16 0:29 ` [PATCH 3/6] drm_modes: add videomode_from_drm_display_mode slongerbeam
2014-12-16 0:29 ` [PATCH 4/6] imx-drm: ipuv3-crtc: Implement mode_fixup slongerbeam
2014-12-16 0:29 ` [PATCH 5/6] imx-drm: encoder mode_set must use adjusted mode slongerbeam
2014-12-17 14:03 ` Philipp Zabel [this message]
2014-12-19 0:31 ` Steve Longerbeam
2014-12-16 0:29 ` [PATCH 6/6] gpu: ipu-v3: Use videomode in struct ipu_di_signal_cfg slongerbeam
2014-12-17 14:02 ` Philipp Zabel
2014-12-19 0:34 ` Steve Longerbeam
2014-12-17 14:18 ` [PATCH 0/6] imx-drm: ipuv3-crtc: Implement mode_fixup Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418824983.3155.45.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=slongerbeam@gmail.com \
--cc=steve_longerbeam@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox