dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Longerbeam <slongerbeam@gmail.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Steve Longerbeam <steve_longerbeam@mentor.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 6/6] gpu: ipu-v3: Use videomode in struct ipu_di_signal_cfg
Date: Thu, 18 Dec 2014 16:34:04 -0800	[thread overview]
Message-ID: <5493727C.3090306@gmail.com> (raw)
In-Reply-To: <1418824976.3155.44.camel@pengutronix.de>

On 12/17/2014 06:02 AM, Philipp Zabel wrote:
>
> The interlaced parameter to ipu_dc_init_sync is of type bool, so the
> ()?true:false is superfluous.

fixed.

>
> [...]
>> @@ -433,10 +437,11 @@ static void ipu_di_config_clock(struct ipu_di *di,
>>  			unsigned long in_rate;
>>  			unsigned div;
>>  
>> -			clk_set_rate(clk, sig->pixelclock);
>> +			clk_set_rate(clk, sig->mode.pixelclock);
>>  
>>  			in_rate = clk_get_rate(clk);
>> -			div = (in_rate + sig->pixelclock / 2) / sig->pixelclock;
>> +			div = (in_rate + sig->mode.pixelclock / 2) /
>> +				sig->mode.pixelclock;
> Let's use this opportunity to switch to DIV_ROUND_CLOSEST here ...

I'll add a separate patch for that.

Steve

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2014-12-19  0:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-16  0:29 [PATCH 0/6] imx-drm: ipuv3-crtc: Implement mode_fixup slongerbeam
2014-12-16  0:29 ` [PATCH 1/6] gpu: ipu-di: Add ipu_di_adjust_videomode() slongerbeam
2014-12-17 12:27   ` Fabio Estevam
2014-12-18 19:05     ` Steve Longerbeam
2014-12-16  0:29 ` [PATCH 2/6] gpu: ipu-di: remove some non-functional code slongerbeam
2014-12-16  0:29 ` [PATCH 3/6] drm_modes: add videomode_from_drm_display_mode slongerbeam
2014-12-16  0:29 ` [PATCH 4/6] imx-drm: ipuv3-crtc: Implement mode_fixup slongerbeam
2014-12-16  0:29 ` [PATCH 5/6] imx-drm: encoder mode_set must use adjusted mode slongerbeam
2014-12-17 14:03   ` Philipp Zabel
2014-12-19  0:31     ` Steve Longerbeam
2014-12-16  0:29 ` [PATCH 6/6] gpu: ipu-v3: Use videomode in struct ipu_di_signal_cfg slongerbeam
2014-12-17 14:02   ` Philipp Zabel
2014-12-19  0:34     ` Steve Longerbeam [this message]
2014-12-17 14:18 ` [PATCH 0/6] imx-drm: ipuv3-crtc: Implement mode_fixup Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5493727C.3090306@gmail.com \
    --to=slongerbeam@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=p.zabel@pengutronix.de \
    --cc=steve_longerbeam@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox