From: Philipp Zabel <p.zabel@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
treding@nvidia.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/bridge: dw_hdmi: Return the real error on drm_bridge_attach() failure
Date: Thu, 29 Jan 2015 12:16:10 +0100 [thread overview]
Message-ID: <1422530170.7752.36.camel@pengutronix.de> (raw)
In-Reply-To: <1422528502-5252-1-git-send-email-festevam@gmail.com>
Am Donnerstag, den 29.01.2015, 08:48 -0200 schrieb Fabio Estevam:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> drm_bridge_attach() may return different errors on failure, not just -EINVAL, so
> it is better to propagate the real error instead.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/gpu/drm/bridge/dw_hdmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
> index cd6a706..fcae66a 100644
> --- a/drivers/gpu/drm/bridge/dw_hdmi.c
> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c
> @@ -1528,7 +1528,7 @@ static int dw_hdmi_register(struct drm_device *drm, struct dw_hdmi *hdmi)
> ret = drm_bridge_attach(drm, bridge);
> if (ret) {
> DRM_ERROR("Failed to initialize bridge with drm\n");
> - return -EINVAL;
> + return ret;
> }
>
> encoder->bridge = bridge;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-01-29 11:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 10:48 [PATCH] drm/bridge: dw_hdmi: Return the real error on drm_bridge_attach() failure Fabio Estevam
2015-01-29 11:16 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422530170.7752.36.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox