[PATCH] drm/bridge: dw_hdmi: Return the real error on drm_bridge_attach() failure

[PATCH] drm/bridge: dw_hdmi: Return the real error on drm_bridge_attach() failure

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

drm_bridge_attach() may return different errors on failure, not just -EINVAL, so
it is better to propagate the real error instead.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/gpu/drm/bridge/dw_hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
index cd6a706..fcae66a 100644
--- a/drivers/gpu/drm/bridge/dw_hdmi.c
+++ b/drivers/gpu/drm/bridge/dw_hdmi.c
@@ -1528,7 +1528,7 @@ static int dw_hdmi_register(struct drm_device *drm, struct dw_hdmi *hdmi)
 	ret = drm_bridge_attach(drm, bridge);
 	if (ret) {
 		DRM_ERROR("Failed to initialize bridge with drm\n");
-		return -EINVAL;
+		return ret;
 	}
 
 	encoder->bridge = bridge;
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/bridge: dw_hdmi: Return the real error on drm_bridge_attach() failure

[Philipp Zabel]

Am Donnerstag, den 29.01.2015, 08:48 -0200 schrieb Fabio Estevam:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> drm_bridge_attach() may return different errors on failure, not just -EINVAL, so
> it is better to propagate the real error instead.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

> ---
>  drivers/gpu/drm/bridge/dw_hdmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
> index cd6a706..fcae66a 100644
> --- a/drivers/gpu/drm/bridge/dw_hdmi.c
> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c
> @@ -1528,7 +1528,7 @@ static int dw_hdmi_register(struct drm_device *drm, struct dw_hdmi *hdmi)
>  	ret = drm_bridge_attach(drm, bridge);
>  	if (ret) {
>  		DRM_ERROR("Failed to initialize bridge with drm\n");
> -		return -EINVAL;
> +		return ret;
>  	}
>  
>  	encoder->bridge = bridge;


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel