From: Greg Hackmann <ghackmann@google.com>
To: dri-devel@lists.freedesktop.org
Subject: [PATCH libdrm] Add missing <strings.h> includes
Date: Thu, 16 Apr 2015 10:55:40 -0700 [thread overview]
Message-ID: <1429206940-27525-1-git-send-email-ghackmann@google.com> (raw)
A couple of files use ffs() without explicitly including strings.h.
Some systems will pull in ffs()'s declaration through another header
anyway, but not when compiling against bionic in AOSP master.
Signed-off-by: Greg Hackmann <ghackmann@google.com>
---
nouveau/nouveau.c | 1 +
tests/modetest/modetest.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/nouveau/nouveau.c b/nouveau/nouveau.c
index 2d95b74..22e0f80 100644
--- a/nouveau/nouveau.c
+++ b/nouveau/nouveau.c
@@ -30,6 +30,7 @@
#include <stdlib.h>
#include <stdint.h>
#include <string.h>
+#include <strings.h>
#include <stdbool.h>
#include <assert.h>
#include <errno.h>
diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c
index 53dfe05..63d2059 100644
--- a/tests/modetest/modetest.c
+++ b/tests/modetest/modetest.c
@@ -50,6 +50,7 @@
#include <inttypes.h>
#include <unistd.h>
#include <string.h>
+#include <strings.h>
#include <errno.h>
#include <sys/poll.h>
#include <sys/time.h>
--
2.2.0.rc0.207.ga3a616c
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2015-04-16 17:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 17:55 Greg Hackmann [this message]
2015-04-21 18:31 ` [PATCH libdrm] Add missing <strings.h> includes Emil Velikov
2015-04-22 16:19 ` Greg Hackmann
2015-04-23 16:56 ` Emil Velikov
2015-04-27 7:09 ` Chih-Wei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429206940-27525-1-git-send-email-ghackmann@google.com \
--to=ghackmann@google.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox