From: Emil Velikov <emil.l.velikov@gmail.com>
To: Greg Hackmann <ghackmann@google.com>, dri-devel@lists.freedesktop.org
Cc: emil.l.velikov@gmail.com
Subject: Re: [PATCH libdrm] Add missing <strings.h> includes
Date: Tue, 21 Apr 2015 18:31:54 +0000 [thread overview]
Message-ID: <5536979A.9070306@gmail.com> (raw)
In-Reply-To: <1429206940-27525-1-git-send-email-ghackmann@google.com>
Hi Greg,
On 16/04/15 17:55, Greg Hackmann wrote:
> A couple of files use ffs() without explicitly including strings.h.
> Some systems will pull in ffs()'s declaration through another header
> anyway, but not when compiling against bionic in AOSP master.
>
> Signed-off-by: Greg Hackmann <ghackmann@google.com>
Thanks for the patch.
I'm not sure why I haven't hit this while building with Android-x86's
bionic, although it's the right thing to do.
I will give it a few days more for anyone to comment and I'll push it.
From a quick look I cannot see libdrm in the AOSP build. Are you
experimenting with a libdrm based hwcompositor again :-)
Cheers
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-04-21 17:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 17:55 [PATCH libdrm] Add missing <strings.h> includes Greg Hackmann
2015-04-21 18:31 ` Emil Velikov [this message]
2015-04-22 16:19 ` Greg Hackmann
2015-04-23 16:56 ` Emil Velikov
2015-04-27 7:09 ` Chih-Wei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5536979A.9070306@gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ghackmann@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox