From: David Herrmann <dh.herrmann@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH 1/3] drm: drop unused 'magicfree' list
Date: Mon, 4 May 2015 16:05:12 +0200 [thread overview]
Message-ID: <1430748314-862-1-git-send-email-dh.herrmann@gmail.com> (raw)
This list is write-only. It's never used for read-access, so no reason to
keep it around. Drop it!
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
---
drivers/gpu/drm/drm_auth.c | 3 ---
drivers/gpu/drm/drm_drv.c | 1 -
include/drm/drmP.h | 2 --
3 files changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_auth.c b/drivers/gpu/drm/drm_auth.c
index fc8e8aa..8a37524 100644
--- a/drivers/gpu/drm/drm_auth.c
+++ b/drivers/gpu/drm/drm_auth.c
@@ -37,7 +37,6 @@
#include "drm_internal.h"
struct drm_magic_entry {
- struct list_head head;
struct drm_hash_item hash_item;
struct drm_file *priv;
};
@@ -93,7 +92,6 @@ static int drm_add_magic(struct drm_master *master, struct drm_file *priv,
entry->hash_item.key = (unsigned long)magic;
mutex_lock(&dev->struct_mutex);
drm_ht_insert_item(&master->magiclist, &entry->hash_item);
- list_add_tail(&entry->head, &master->magicfree);
mutex_unlock(&dev->struct_mutex);
return 0;
@@ -123,7 +121,6 @@ int drm_remove_magic(struct drm_master *master, drm_magic_t magic)
}
pt = drm_hash_entry(hash, struct drm_magic_entry, hash_item);
drm_ht_remove_item(&master->magiclist, hash);
- list_del(&pt->head);
mutex_unlock(&dev->struct_mutex);
kfree(pt);
diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index 48f7359..26ed9fe 100644
--- a/drivers/gpu/drm/drm_drv.c
+++ b/drivers/gpu/drm/drm_drv.c
@@ -109,7 +109,6 @@ struct drm_master *drm_master_create(struct drm_minor *minor)
kfree(master);
return NULL;
}
- INIT_LIST_HEAD(&master->magicfree);
master->minor = minor;
return master;
diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index 62c40777..80be07a 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -356,7 +356,6 @@ struct drm_lock_data {
* @unique: Unique identifier: e.g. busid. Protected by drm_global_mutex.
* @unique_len: Length of unique field. Protected by drm_global_mutex.
* @magiclist: Hash of used authentication tokens. Protected by struct_mutex.
- * @magicfree: List of used authentication tokens. Protected by struct_mutex.
* @lock: DRI lock information.
* @driver_priv: Pointer to driver-private information.
*/
@@ -366,7 +365,6 @@ struct drm_master {
char *unique;
int unique_len;
struct drm_open_hash magiclist;
- struct list_head magicfree;
struct drm_lock_data lock;
void *driver_priv;
};
--
2.3.7
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2015-05-04 14:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 14:05 David Herrmann [this message]
2015-05-04 14:05 ` [PATCH 2/3] drm: simplify authentication management David Herrmann
2015-05-04 14:46 ` Chris Wilson
2015-05-04 15:02 ` David Herrmann
2015-05-04 15:11 ` Chris Wilson
2015-05-04 15:14 ` David Herrmann
2015-05-04 15:25 ` Chris Wilson
2015-05-04 16:28 ` David Herrmann
2015-05-04 16:49 ` Chris Wilson
2015-05-04 18:21 ` David Herrmann
2015-05-04 18:19 ` [PATCH v2 " David Herrmann
2015-05-04 18:33 ` Chris Wilson
2015-05-04 18:37 ` David Herrmann
2015-05-04 19:01 ` [PATCH v3 " David Herrmann
2015-05-04 14:05 ` [PATCH 3/3] drm: simplify master cleanup David Herrmann
2015-05-04 14:47 ` Chris Wilson
2015-05-05 7:47 ` Daniel Vetter
2015-05-04 14:33 ` [PATCH 1/3] drm: drop unused 'magicfree' list Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430748314-862-1-git-send-email-dh.herrmann@gmail.com \
--to=dh.herrmann@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox