From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
David Herrmann <dh.herrmann@gmail.com>,
dri-devel@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 3/3] drm: simplify master cleanup
Date: Tue, 5 May 2015 09:47:11 +0200 [thread overview]
Message-ID: <20150505074711.GA30184@phenom.ffwll.local> (raw)
In-Reply-To: <20150504144713.GE22099@nuc-i3427.alporthouse.com>
On Mon, May 04, 2015 at 03:47:13PM +0100, Chris Wilson wrote:
> On Mon, May 04, 2015 at 04:05:14PM +0200, David Herrmann wrote:
> > In drm_master_destroy() we _free_ the master object. There is no reason to
> > hold any locks while dropping its static members, nor do we have to reset
> > it to 0.
> >
> > Furthermore, kfree() already does NULL checks, so call it directly on
> > master->unique and drop the redundant reset-code.
> >
> > Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Both kernel and igt patches applied, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-05-05 7:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 14:05 [PATCH 1/3] drm: drop unused 'magicfree' list David Herrmann
2015-05-04 14:05 ` [PATCH 2/3] drm: simplify authentication management David Herrmann
2015-05-04 14:46 ` Chris Wilson
2015-05-04 15:02 ` David Herrmann
2015-05-04 15:11 ` Chris Wilson
2015-05-04 15:14 ` David Herrmann
2015-05-04 15:25 ` Chris Wilson
2015-05-04 16:28 ` David Herrmann
2015-05-04 16:49 ` Chris Wilson
2015-05-04 18:21 ` David Herrmann
2015-05-04 18:19 ` [PATCH v2 " David Herrmann
2015-05-04 18:33 ` Chris Wilson
2015-05-04 18:37 ` David Herrmann
2015-05-04 19:01 ` [PATCH v3 " David Herrmann
2015-05-04 14:05 ` [PATCH 3/3] drm: simplify master cleanup David Herrmann
2015-05-04 14:47 ` Chris Wilson
2015-05-05 7:47 ` Daniel Vetter [this message]
2015-05-04 14:33 ` [PATCH 1/3] drm: drop unused 'magicfree' list Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150505074711.GA30184@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dh.herrmann@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox