[PATCH v3 RESEND 0/5] Remaining part of kill off set_irq_flags usage

[PATCH v3 RESEND 0/5] Remaining part of kill off set_irq_flags usage

[Rob Herring]

Thomas,

As requested, here are the remaining patches for killing off 
set_irq_flags which have not been picked up. The rest of the 
series has been picked up and are in -next. 

Rob

Rob Herring (5):
  gpu/drm: kill off set_irq_flags usage
  irqchip: kill off set_irq_flags usage
  sh: kill off set_irq_flags usage
  ARM: remove ununsed set_irq_flags
  arm64: remove ununsed set_irq_flags

 arch/arm/include/asm/hw_irq.h             |  6 ------
 arch/arm/kernel/irq.c                     | 20 --------------------
 arch/arm64/include/asm/hardirq.h          |  5 -----
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c   |  1 -
 drivers/gpu/ipu-v3/ipu-common.c           |  3 +--
 drivers/irqchip/exynos-combiner.c         |  2 +-
 drivers/irqchip/irq-armada-370-xp.c       |  3 +--
 drivers/irqchip/irq-bcm2835.c             |  2 +-
 drivers/irqchip/irq-clps711x.c            |  6 +++---
 drivers/irqchip/irq-gic-v3.c              |  5 ++---
 drivers/irqchip/irq-gic.c                 |  4 ++--
 drivers/irqchip/irq-hip04.c               |  4 ++--
 drivers/irqchip/irq-keystone.c            |  2 +-
 drivers/irqchip/irq-mmp.c                 |  3 ---
 drivers/irqchip/irq-mxs.c                 |  1 -
 drivers/irqchip/irq-renesas-intc-irqpin.c |  1 -
 drivers/irqchip/irq-renesas-irqc.c        |  1 -
 drivers/irqchip/irq-s3c24xx.c             | 14 ++------------
 drivers/irqchip/irq-sun4i.c               |  2 +-
 drivers/irqchip/irq-versatile-fpga.c      |  2 +-
 drivers/irqchip/irq-vic.c                 |  2 +-
 drivers/irqchip/irq-vt8500.c              |  1 -
 drivers/irqchip/spear-shirq.c             |  1 -
 drivers/sh/intc/internals.h               | 10 +---------
 24 files changed, 20 insertions(+), 81 deletions(-)

-- 
2.1.4

[RESEND PATCH v3 1/5] gpu/drm: kill off set_irq_flags usage

[Rob Herring]

set_irq_flags is ARM specific with custom flags which have genirq
equivalents. Convert drivers to use the genirq interfaces directly, so we
can kill off set_irq_flags. The translation of flags is as follows:

IRQF_VALID -> !IRQ_NOREQUEST
IRQF_PROBE -> !IRQ_NOPROBE
IRQF_NOAUTOEN -> IRQ_NOAUTOEN

For IRQs managed by an irqdomain, the irqdomain core code handles clearing
and setting IRQ_NOREQUEST already, so there is no need to do this in
.map() functions and we can simply remove the set_irq_flags calls. Some
users also modify IRQ_NOPROBE and this has been maintained although it
is not clear that is really needed. There appears to be a great deal of
blind copy and paste of this code.

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
---
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c | 1 -
 drivers/gpu/ipu-v3/ipu-common.c         | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c
index 33bd4c6..9a6a747 100644
--- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c
+++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c
@@ -165,7 +165,6 @@ static int mdp5_hw_irqdomain_map(struct irq_domain *d,
 
 	irq_set_chip_and_handler(irq, &mdp5_hw_irq_chip, handle_level_irq);
 	irq_set_chip_data(irq, mdp5_kms);
-	set_irq_flags(irq, IRQF_VALID);
 
 	return 0;
 }
diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c
index 00f2058..4ac9e05 100644
--- a/drivers/gpu/ipu-v3/ipu-common.c
+++ b/drivers/gpu/ipu-v3/ipu-common.c
@@ -1099,8 +1099,7 @@ static int ipu_irq_init(struct ipu_soc *ipu)
 	}
 
 	ret = irq_alloc_domain_generic_chips(ipu->domain, 32, 1, "IPU",
-					     handle_level_irq, 0,
-					     IRQF_VALID, 0);
+					     handle_level_irq, 0, 0, 0);
 	if (ret < 0) {
 		dev_err(ipu->dev, "failed to alloc generic irq chips\n");
 		irq_domain_remove(ipu->domain);
-- 
2.1.4

Re: [PATCH v3 RESEND 0/5] Remaining part of kill off set_irq_flags usage

[Thomas Gleixner]

On Sat, 29 Aug 2015, Rob Herring wrote:
> Thomas,
> 
> As requested, here are the remaining patches for killing off 
> set_irq_flags which have not been picked up. The rest of the 
> series has been picked up and are in -next. 

I pick it up, stick it into tip irq/urgent let it brew for a couple of
days in next and send it to Linus after that.

Thanks,

	tglx

Re: [PATCH v3 RESEND 0/5] Remaining part of kill off set_irq_flags usage

[Rob Herring]

On 08/29/2015 06:01 PM, Rob Herring wrote:
> Thomas,
> 
> As requested, here are the remaining patches for killing off 
> set_irq_flags which have not been picked up. The rest of the 
> series has been picked up and are in -next. 

Thomas, are you going to pick up these remaining patches?

Rob

> 
> Rob
> 
> Rob Herring (5):
>   gpu/drm: kill off set_irq_flags usage
>   irqchip: kill off set_irq_flags usage
>   sh: kill off set_irq_flags usage
>   ARM: remove ununsed set_irq_flags
>   arm64: remove ununsed set_irq_flags
> 
>  arch/arm/include/asm/hw_irq.h             |  6 ------
>  arch/arm/kernel/irq.c                     | 20 --------------------
>  arch/arm64/include/asm/hardirq.h          |  5 -----
>  drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c   |  1 -
>  drivers/gpu/ipu-v3/ipu-common.c           |  3 +--
>  drivers/irqchip/exynos-combiner.c         |  2 +-
>  drivers/irqchip/irq-armada-370-xp.c       |  3 +--
>  drivers/irqchip/irq-bcm2835.c             |  2 +-
>  drivers/irqchip/irq-clps711x.c            |  6 +++---
>  drivers/irqchip/irq-gic-v3.c              |  5 ++---
>  drivers/irqchip/irq-gic.c                 |  4 ++--
>  drivers/irqchip/irq-hip04.c               |  4 ++--
>  drivers/irqchip/irq-keystone.c            |  2 +-
>  drivers/irqchip/irq-mmp.c                 |  3 ---
>  drivers/irqchip/irq-mxs.c                 |  1 -
>  drivers/irqchip/irq-renesas-intc-irqpin.c |  1 -
>  drivers/irqchip/irq-renesas-irqc.c        |  1 -
>  drivers/irqchip/irq-s3c24xx.c             | 14 ++------------
>  drivers/irqchip/irq-sun4i.c               |  2 +-
>  drivers/irqchip/irq-versatile-fpga.c      |  2 +-
>  drivers/irqchip/irq-vic.c                 |  2 +-
>  drivers/irqchip/irq-vt8500.c              |  1 -
>  drivers/irqchip/spear-shirq.c             |  1 -
>  drivers/sh/intc/internals.h               | 10 +---------
>  24 files changed, 20 insertions(+), 81 deletions(-)
> 

Re: [PATCH v3 RESEND 0/5] Remaining part of kill off set_irq_flags usage

[Thomas Gleixner]

On Wed, 16 Sep 2015, Rob Herring wrote:

> On 08/29/2015 06:01 PM, Rob Herring wrote:
> > Thomas,
> > 
> > As requested, here are the remaining patches for killing off 
> > set_irq_flags which have not been picked up. The rest of the 
> > series has been picked up and are in -next. 
> 
> Thomas, are you going to pick up these remaining patches?

Yes. I'm going to push them out later today.